Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt test suite configuration with YAML feature default+flows for non-product selection in s390x #15524

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

hjluo
Copy link
Contributor

@hjluo hjluo commented Sep 14, 2022

For s390x, we need to design a single default YAML to handle its specific workflow. we use the default+flow feature to have one place to update it for s390x's strange variation.

@jknphy
Copy link
Contributor

jknphy commented Sep 19, 2022

As a first step, you need to convert the yaml schedule schedule/yast/select_modules_and_patterns+registration/select_modules_and_patterns+registration@s390x.yaml to use base-on-default approach (you can skip flows to start, then we will see if we need them) by detecting the differences with default.yaml and overwriting them:

schedule:
   registration:
      - installation/registration/skip_registration
   extension_module_selection:
      - installation/module_selection/select_nonconflicting_modules
   add_on_product:
      - installation/add_on_product_installation/accept_add_on_installation
   ...

Once you have that, we need to consider what we can extract to a file default_s390x given that there are two backends for s390x and also there are different between Full and Online Medium. Ideally the resulting file from this task could be a base for future s390x test suites, but you don't need to go that far, perhaps to add what is more general of both s390x backend should suffice for now.

@hjluo
Copy link
Contributor Author

hjluo commented Sep 22, 2022

@jknphy Thanks for the comments and I've updated the PR with my understanding. please correct me if I'm wrong.

schedule/yast/sle/flows/s390x_default.yaml Outdated Show resolved Hide resolved
schedule/yast/sle/flows/s390x_default.yaml Outdated Show resolved Hide resolved
schedule/yast/sle/flows/s390x_default.yaml Outdated Show resolved Hide resolved
schedule/yast/sle/flows/s390x_default.yaml Outdated Show resolved Hide resolved
schedule/yast/sle/flows/s390x_default.yaml Outdated Show resolved Hide resolved
schedule/yast/sle/flows/s390x_default.yaml Outdated Show resolved Hide resolved
schedule/yast/sle/flows/s390x_default.yaml Outdated Show resolved Hide resolved
schedule/yast/sle/flows/s390x_default.yaml Outdated Show resolved Hide resolved
schedule/yast/sle/flows/s390x_default.yaml Outdated Show resolved Hide resolved
@jknphy jknphy changed the title [WIP]Adapt test suite with default+flows for s390x [WIP] Adapt test suite with default+flows for s390x Sep 23, 2022
@hjluo hjluo force-pushed the s390x_default_flow branch 4 times, most recently from 9dc2a1a to 4b77cb0 Compare September 27, 2022 09:02
@hjluo hjluo changed the title [WIP] Adapt test suite with default+flows for s390x Adapt test suite with default+flows for s390x yast Sep 27, 2022
Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to create a default schedule for s390x kvm for Online, and do the necessary overwrite on a new schedule file for this Offline scenario.

schedule/yast/sle/flows/default_s390x_kvm.yaml Outdated Show resolved Hide resolved
@hjluo
Copy link
Contributor Author

hjluo commented Sep 27, 2022

@jknphy thank you for your comments. I've made some changes per your comments.
please take a look again. Thanks.

@hjluo hjluo force-pushed the s390x_default_flow branch 13 times, most recently from 48e7ff4 to 2725d94 Compare September 28, 2022 08:39
@coolgw coolgw added the qe-yast label Sep 29, 2022
@hjluo hjluo force-pushed the s390x_default_flow branch 3 times, most recently from e50992b to 09d2f42 Compare October 10, 2022 06:42
@hjluo hjluo force-pushed the s390x_default_flow branch 5 times, most recently from f4109f6 to efdb4fb Compare October 11, 2022 02:05
@jknphy
Copy link
Contributor

jknphy commented Oct 11, 2022

Looks almost done besides those comments.
Please take a look to MR, to only set the default for those test suites, not the whole arch.

@hjluo hjluo force-pushed the s390x_default_flow branch 5 times, most recently from b73e440 to 9ebfe99 Compare October 11, 2022 09:37
@hjluo
Copy link
Contributor Author

hjluo commented Oct 11, 2022

Looks almost done besides those comments. Please take a look to MR, to only set the default for those test suites, not the whole arch.

I've resolved all your comments please take a look again, and I've updated the VR.
thanks a lot.

@jknphy
Copy link
Contributor

jknphy commented Oct 11, 2022

Please, don't resolve comment when you answer with another question, it makes easier for the reviewer to not miss it.
LGTM, just a small detail there, could you also update the MR?

@hjluo hjluo force-pushed the s390x_default_flow branch 2 times, most recently from ca731fd to 52d33e8 Compare October 12, 2022 09:52
For s390x, we need to design a single default yaml to handle it's
speicific workflow. we use the default+flow feature to have one place
to update it for s390x's strange variation.
@hjluo hjluo changed the title Adapt test suite with default+flows for s390x yast Adapt test suite configuration with YAML feature default+flows for non-product selection in s390x Oct 12, 2022
@hjluo
Copy link
Contributor Author

hjluo commented Oct 12, 2022

I've updated the code and the VRs, please take a look again. thanks a lot.

@jknphy jknphy merged commit e980b71 into os-autoinst:master Oct 13, 2022
@hjluo hjluo deleted the s390x_default_flow branch October 14, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants