-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt test suite configuration with YAML feature default+flows for non-product selection in s390x #15524
Conversation
As a first step, you need to convert the yaml schedule
Once you have that, we need to consider what we can extract to a file |
8b0f78d
to
d0f5ed2
Compare
@jknphy Thanks for the comments and I've updated the PR with my understanding. please correct me if I'm wrong. |
d0f5ed2
to
e781a47
Compare
...select_modules_and_patterns+registration/select_modules_and_patterns+registration@s390x.yaml
Show resolved
Hide resolved
9dc2a1a
to
4b77cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to create a default schedule for s390x kvm for Online, and do the necessary overwrite on a new schedule file for this Offline scenario.
@jknphy thank you for your comments. I've made some changes per your comments. |
48e7ff4
to
2725d94
Compare
e50992b
to
09d2f42
Compare
f4109f6
to
efdb4fb
Compare
schedule/yast/textmode_installation_minimal_role/textmode_installation_minimal_role@s390x.yaml
Show resolved
Hide resolved
efdb4fb
to
1ba650b
Compare
schedule/yast/textmode_installation_minimal_role/textmode_installation_minimal_role@s390x.yaml
Outdated
Show resolved
Hide resolved
...select_modules_and_patterns+registration/select_modules_and_patterns+registration@s390x.yaml
Show resolved
Hide resolved
Looks almost done besides those comments. |
b73e440
to
9ebfe99
Compare
I've resolved all your comments please take a look again, and I've updated the VR. |
Please, don't resolve comment when you answer with another question, it makes easier for the reviewer to not miss it. |
ca731fd
to
52d33e8
Compare
For s390x, we need to design a single default yaml to handle it's speicific workflow. we use the default+flow feature to have one place to update it for s390x's strange variation.
52d33e8
to
06315e8
Compare
I've updated the code and the VRs, please take a look again. thanks a lot. |
For s390x, we need to design a single default YAML to handle its specific workflow. we use the default+flow feature to have one place to update it for s390x's strange variation.
Related ticket:
Needles:
Verification run:
Related MR:
https://gitlab.suse.de/qsf-y/qa-sle-functional-y/-/merge_requests/419