Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove /var/lib/wicked/*.xml also on svirt backend #15685

Merged
merged 1 commit into from Oct 12, 2022
Merged

Remove /var/lib/wicked/*.xml also on svirt backend #15685

merged 1 commit into from Oct 12, 2022

Conversation

pdostal
Copy link
Member

@pdostal pdostal commented Oct 11, 2022 •
edited

@pdostal pdostal marked this pull request as draft October 11, 2022 12:55
@pdostal pdostal changed the title Draft: Remove /var/lib/wicked/*.xml also on svirt backend Remove /var/lib/wicked/*.xml also on svirt backend Oct 11, 2022
@pdostal pdostal marked this pull request as ready for review October 12, 2022 08:54
@rfan1
Copy link
Contributor

rfan1 commented Oct 12, 2022

I suggest adding some comments in line 12.

@pdostal pdostal force-pushed the svirt_duid branch 3 times, most recently from 435669a to c6de3cf Compare October 12, 2022 09:32
@pdostal
Copy link
Member Author

pdostal commented Oct 12, 2022

I suggest adding some comments in line 12.

Done. Is that OK for you?

@BillAnastasiadis
Copy link
Contributor

LGTM. Parallel jobs using the same cqow seem to have no problems now.

@BillAnastasiadis BillAnastasiadis merged commit fce7fe3 into os-autoinst:master Oct 12, 2022
@foursixnine foursixnine mentioned this pull request Oct 17, 2022
Closed
@pdostal pdostal deleted the svirt_duid branch December 28, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfan1 rfan1 rfan1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pdostal @rfan1 @BillAnastasiadis