New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select yast development pattern only #15693
Merged
JRivrain
merged 1 commit into
os-autoinst:master
from
lemon-suse:select_pattern_only_yast_development
Oct 27, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # SUSE's openQA tests | ||
| # | ||
| # Copyright 2022 SUSE LLC | ||
| # SPDX-License-Identifier: FSFAP | ||
|
|
||
| # Summary: Select a pattern from the bottom | ||
| # You can pass | ||
| # PATTERNS=yast-development | ||
| # | ||
| # Maintainer: QA SLE YaST team <qa-sle-yast@suse.de> | ||
|
|
||
| use base 'y2_installbase'; | ||
| use strict; | ||
| use warnings; | ||
| use testapi; | ||
|
|
||
| sub run { | ||
| my ($self) = @_; | ||
| $self->go_to_patterns(); | ||
| my @patterns = grep($_, split(/,/, get_required_var('PATTERNS'))); | ||
| # delete special 'default' key from the check | ||
| @patterns = grep { $_ ne 'default' } @patterns; | ||
| # specific for yast development at the end of list | ||
| wait_screen_change { send_key 'alt-end'; } | ||
| save_screenshot; | ||
| $self->select_visible_unselected_patterns([@patterns]); | ||
| $self->accept_changes(); | ||
| } | ||
|
|
||
| 1; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this line, we should remove 'default' from settings via MR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically yes, however someone checking the settings can interpret that "PATTERNS=yast_develpoment" may mean only yast development, and not default patterns, as all other tests using that variable specify it otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our way is to check the name of the test module, if we pass as settings or test data is just by our own convenience, we have
tests/installation/select_only_visible_patterns_from_top.pmfor disambiguation withonlyin the name.