Btrfs quota group improvements poo#11446 #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravciak
force-pushed
the
btrfs
branch
2 times, most recently
from
367b48e
to
7f0dd22
Compare
| my $dest = "/mnt/qg"; | ||
|
|
||
| # poo#11446 | ||
| # Creating qgroups in a heirarchy for multiple subvolumes, putting data into them and then running btrfsck on the hard disk |
There was a problem hiding this comment.
please break lines in comment and s/heirarchy/hierarchy/
kravciak
changed the title
|
|
||
| # TODO? check btrfsck output | ||
| script_run "cd; umount $dest"; | ||
| assert_script_run "btrfsck /dev/vdb"; |
There was a problem hiding this comment.
what if any of the script_run's fail but you continue? You could get very misleading results and screen output. I recommend to use assert_script_run everywhere except where you explicitly check for the return value of script_run
kravciak
force-pushed
the
btrfs
branch
2 times, most recently
from
f6f166b
to
37bf727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local runs:
TW: http://dhcp91.suse.cz/tests/1820
SLES: http://dhcp91.suse.cz/tests/1819