Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible: Do not install python3-yamllint on transactional systems and run trup_call in non-interactive mode #15846

Merged
merged 1 commit into from Nov 14, 2022

Conversation

pdostal
Copy link
Member

@pdostal pdostal commented Nov 7, 2022

Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall approach is good, but there are some inconsistencies.

tests/console/ansible.pm Outdated Show resolved Hide resolved
tests/console/ansible.pm Outdated Show resolved Hide resolved
tests/console/ansible.pm Outdated Show resolved Hide resolved
Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pdostal pdostal force-pushed the ansible branch 2 times, most recently from b456fbd to 570d4bb Compare November 14, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants