Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transactional/rebootmgr: Adjust to 2.0 and do some cleanup #15869

Merged
merged 2 commits into from
Nov 9, 2022
Merged

transactional/rebootmgr: Adjust to 2.0 and do some cleanup #15869

merged 2 commits into from
Nov 9, 2022

Conversation

Vogtinator
Copy link
Member

@Vogtinator Vogtinator commented Nov 9, 2022 •
edited
Loading

@Vogtinator
transactional/rebootmgr: Don't expect the reboot at the maint window …
67c5971 
…start

It was a bug that the reboot always happened at the first possible time in the
maintenance window. Make the window shorter and give it a bit more time.
@Vogtinator
transactional/rebootmgr: Some cleanups
a134559 
- Make the duration parameter mandatory
- The etcd function is dead and the functionality removed in rebootmgr, drop it
- Call get_utt_packages to not rely on previous modules
- Drop "tput civis", shouldn't be needed and doesn't persist past reboots
  anyway
@Vogtinator Vogtinator marked this pull request as ready for review November 9, 2022 10:09
mloviska
mloviska approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@mloviska mloviska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be nice to check whether $duration is undef since the default value has been removed and it is up to the caller to remember that it is mandatory from now on

@Vogtinator
Copy link
Member Author

LGTM, it would be nice to check whether $duration is undef since the default value has been removed and it is up to the caller to remember that it is mandatory from now on

IMO not necessary because then the command is invalid and the cause for that is fairly obvious. There aren't any other callers left.

@Vogtinator Vogtinator merged commit ae900b6 into os-autoinst:master Nov 9, 2022
@Vogtinator Vogtinator deleted the fixfixedrebootmgr branch November 9, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloviska mloviska mloviska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Vogtinator @mloviska