New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable interactive installation for HA with libyui #15990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chcao
force-pushed
the
ha_installation_libyui
branch
2 times, most recently
from
November 29, 2022 09:18
7c16a80
to
e088f9d
Compare
jknphy
reviewed
Nov 29, 2022
schedule/yast/textmode/ha_textmode_skip_registration_s390x.yaml
Outdated
Show resolved
Hide resolved
chcao
changed the title
Enable interactive installation for HA with libyui
[WIP] Enable interactive installation for HA with libyui
Dec 1, 2022
chcao
force-pushed
the
ha_installation_libyui
branch
2 times, most recently
from
December 1, 2022 11:03
011093d
to
20f7860
Compare
coolgw
reviewed
Dec 1, 2022
chcao
force-pushed
the
ha_installation_libyui
branch
2 times, most recently
from
December 1, 2022 14:02
16e778f
to
abb6802
Compare
jknphy
reviewed
Dec 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than those few changes.
Let's add MR in the first comment as usual (for easy navigation and traceability)
chcao
force-pushed
the
ha_installation_libyui
branch
2 times, most recently
from
December 2, 2022 08:22
b83c414
to
5102997
Compare
chcao
force-pushed
the
ha_installation_libyui
branch
5 times, most recently
from
December 5, 2022 06:41
27cf7b4
to
afa6d2c
Compare
chcao
changed the title
[WIP] Enable interactive installation for HA with libyui
Enable interactive installation for HA with libyui
Dec 5, 2022
chcao
force-pushed
the
ha_installation_libyui
branch
from
December 6, 2022 07:17
afa6d2c
to
2543b25
Compare
jknphy
reviewed
Dec 6, 2022
lib/Installation/ModuleRegistration/SeparateRegCodesController.pm
Outdated
Show resolved
Hide resolved
chcao
force-pushed
the
ha_installation_libyui
branch
2 times, most recently
from
December 12, 2022 06:03
631aa05
to
e5ac5c9
Compare
This pr is to enable interactive installation for HA with libyui rest api, and setup the cases to YaST job group.
chcao
force-pushed
the
ha_installation_libyui
branch
from
December 12, 2022 06:11
e5ac5c9
to
f806541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to enable interactive installation for HA with libyui rest api, and setup the cases to YaST job group.
https://openqa.suse.de/tests/overview?distri=sle&version=15-SP5&build=52.4&groupid=251
cases names:
ha_textmode_skip_registration
ha_textmode_skip_registration_minimal_base
ha_textmode
ha_textmode_minimal_base