Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security/yast2_users/add_users.pm: improve test reliability #16059

Merged
merged 1 commit into from Dec 7, 2022

Conversation

paolostivanin
Copy link
Contributor

@paolostivanin paolostivanin commented Dec 7, 2022

@paolostivanin paolostivanin changed the title add_users.pm: remove root console check [WIP] add_users.pm: remove root console check Dec 7, 2022
@paolostivanin paolostivanin changed the title [WIP] add_users.pm: remove root console check [WIP] add_users.pm: remove useless check Dec 7, 2022
@paolostivanin paolostivanin changed the title [WIP] add_users.pm: remove useless check [WIP] add_users.pm: change rootconsole check Dec 7, 2022
@paolostivanin paolostivanin changed the title [WIP] add_users.pm: change rootconsole check add_users.pm: change rootconsole check Dec 7, 2022
@paolostivanin paolostivanin changed the title add_users.pm: change rootconsole check security/yast2_users/add_users.pm: improve test reliability Dec 7, 2022
Copy link
Contributor

@punkioudi punkioudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paolostivanin paolostivanin merged commit 57e9b35 into os-autoinst:master Dec 7, 2022
@paolostivanin paolostivanin deleted the poo117163 branch December 7, 2022 10:17
@DimStar77
Copy link
Contributor

That's quite broken

the nokogiri warning showing up in some cases should be a workaround needle - and never the expected result. The warning shows up when nokogiri has not been properly rebuilt

This currently breaks stagins: https://openqa.opensuse.org/tests/2934894#step/add_users/35

paolostivanin added a commit to paolostivanin/os-autoinst-distri-opensuse that referenced this pull request Dec 7, 2022
paolostivanin added a commit to paolostivanin/os-autoinst-distri-opensuse that referenced this pull request Dec 7, 2022
paolostivanin added a commit to paolostivanin/os-autoinst-distri-opensuse that referenced this pull request Dec 7, 2022
paolostivanin added a commit to paolostivanin/os-autoinst-distri-opensuse that referenced this pull request Dec 7, 2022
paolostivanin added a commit to paolostivanin/os-autoinst-distri-opensuse that referenced this pull request Dec 7, 2022
paolostivanin added a commit that referenced this pull request Dec 8, 2022
security/yast2_users/add_users.pm: fix issue introduced with #16059
tblume pushed a commit to tblume/os-autoinst-distri-opensuse that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants