Simplify default instance type for ec2 #16061
Merged
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default instance type evaluation doesn't work for ARM instances and is needlessly complicated. This commit changes the behaviour to always returns a `large` instance of the corresponding family (t2 for x86_64 and a1 for arm64), which simplifies the workflow considerably while increasing the running costs only by a negligible amount.
dzedro
approved these changes
Dec 7, 2022
grisu48
changed the title
pdostal
approved these changes
Dec 7, 2022
asmorodskyi
reviewed
Dec 7, 2022
| @@ -126,9 +134,7 @@ sub upload_img { | |||
| my $img_arch = get_var('PUBLIC_CLOUD_ARCH', 'x86_64'); | |||
| my $sec_group = get_var('PUBLIC_CLOUD_EC2_UPLOAD_SECGROUP'); | |||
| my $vpc_subnet = get_var('PUBLIC_CLOUD_EC2_UPLOAD_VPCSUBNET'); | |||
| my @instance_main_type = split(/\./, get_var('PUBLIC_CLOUD_INSTANCE_TYPE')); | |||
| my $instance_size = get_var('PUBLIC_CLOUD_IMAGE_LOCATION') =~ /-SAP-/ ? 'large' : 'micro'; | |||
There was a problem hiding this comment.
isn't you changing SAP related logic ? Have you confirmed this with SAP team ? @ricardobranco777 FYI
There was a problem hiding this comment.
I added this because SAP upload failed with smaller instance. But now is the instance large by default, so should be OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default instance type evaluation doesn't work for ARM instances and is needlessly complicated. This commit changes the behaviour to always returns a
largeinstance of the corresponding family (t2 for x86_64 and a1 for arm64), which simplifies the workflow considerably while increasing the running costs only by a negligible amount.