Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always do a rollback after zfs tests #16200

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Always do a rollback after zfs tests #16200

merged 1 commit into from
Jan 10, 2023

Conversation

grisu48
Copy link
Contributor

@grisu48 grisu48 commented Jan 9, 2023 •
edited
Loading

The zfs test is rather intrusive on the system. To prevent disturbances with other test runs, always do a rollback after the test run.

@grisu48
Always do a rollback after zfs test
3aca1d8 
The zfs test is rather intrusive on the system. To prevent disturbances
with other test runs, always do a rollback after the test run.
@grisu48 grisu48 changed the title WIP: Always do a rollback after zfs test Always do a rollback after zfs tests Jan 9, 2023
rfan1
rfan1 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfan1
Copy link
Contributor

rfan1 commented Jan 10, 2023 •
edited
Loading

Hello @grisu48,
Can you please have a try to 'fail' the zfs test and see we can still hit the problem mentioned in https://progress.opensuse.org/issues/122773?

As the original issue was caused by initial failure at zfs test, then rollback operation failed.

@grisu48
Copy link
Contributor Author

grisu48 commented Jan 10, 2023

Hello @grisu48, Can you please have a try to 'fail' the zfs test and see we can still hit the problem mentioned in https://progress.opensuse.org/issues/122773?

As the original issue was caused by initial failure at zfs test, then rollback operation failed.

I saw that and am still puzzled why the rollback failed. However it works nicely in the verification run

I will schedule a bunch of test runs, see if I can reproduce the issue and report back here.

@grisu48
Copy link
Contributor Author

grisu48 commented Jan 10, 2023

@rfan1 I run 20 test runs (11697 to 11716) and none of them had issues in doing the rollback.

I suggest to proceed with the PR and keep an eye on the test runs to see, if the issue is resolved or keeps popping up. I would not know at this point what we could improve further.

@rfan1
Copy link
Contributor

rfan1 commented Jan 10, 2023

@rfan1 I run 20 test runs (11697 to 11716) and none of them had issues in doing the rollback.

I suggest to proceed with the PR and keep an eye on the test runs to see, if the issue is resolved or keeps popping up. I would not know at this point what we could improve further.

I agree with you, please go ahead to merge this PR, then we can file a new ticket if the issue happens again.

@grisu48
Copy link
Contributor Author

grisu48 commented Jan 10, 2023

@rfan1 I run 20 test runs (11697 to 11716) and none of them had issues in doing the rollback.
I suggest to proceed with the PR and keep an eye on the test runs to see, if the issue is resolved or keeps popping up. I would not know at this point what we could improve further.

I agree with you, please go ahead to merge this PR, then we can file a new ticket if the issue happens again.

Thank you!

@michaelgrifalconi michaelgrifalconi merged commit 29b0d8f into os-autoinst:master Jan 10, 2023
@grisu48 grisu48 deleted the zfs branch January 10, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfan1 rfan1 rfan1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@grisu48 @rfan1 @michaelgrifalconi