Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Distribution provider for ALP #16349

Merged

Conversation

lemon-suse
Copy link
Contributor

@lemon-suse lemon-suse commented Feb 10, 2023

We need add Distribution provider for ALP.

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@lemon-suse lemon-suse force-pushed the Add_distribution_control_for_ALP branch 2 times, most recently from 0568d81 to 2450eb6 Compare February 10, 2023 08:22
lib/DistributionProvider.pm Outdated Show resolved Hide resolved
@lemon-suse lemon-suse force-pushed the Add_distribution_control_for_ALP branch from 2450eb6 to 2c89039 Compare February 10, 2023 09:18
lib/Distribution/Alp.pm Outdated Show resolved Hide resolved
@jknphy
Copy link
Contributor

jknphy commented Feb 10, 2023

(nitpick) In PR/commit title I would say is 'provider' instead of 'control'.

Please specify ticket related and if there is not needles you don't need to write it.
Verification is fine to do it with your draft for firewall but put out of the commit before merging.

@lemon-suse lemon-suse force-pushed the Add_distribution_control_for_ALP branch from 2c89039 to 496b47b Compare February 10, 2023 09:27
@lemon-suse lemon-suse changed the title Add Distribution control for ALP Add Distribution provider for ALP Feb 10, 2023
@lemon-suse lemon-suse force-pushed the Add_distribution_control_for_ALP branch from 496b47b to ec8fd79 Compare February 10, 2023 10:02
@jknphy jknphy merged commit f949b74 into os-autoinst:master Feb 10, 2023
jlausuch pushed a commit to jlausuch/os-autoinst-distri-opensuse that referenced this pull request Feb 10, 2023
…_control_for_ALP

Add Distribution provider for ALP
jlausuch pushed a commit to jlausuch/os-autoinst-distri-opensuse that referenced this pull request Feb 10, 2023
…_control_for_ALP

Add Distribution provider for ALP
jlausuch pushed a commit to jlausuch/os-autoinst-distri-opensuse that referenced this pull request Feb 10, 2023
…_control_for_ALP

Add Distribution provider for ALP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants