Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide CI passed logs for yaml files checking #16356

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Hide CI passed logs for yaml files checking #16356

merged 1 commit into from
Feb 28, 2023

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Feb 13, 2023 •
edited
Loading

@rfan1 rfan1 added the WIP Work in progress label Feb 13, 2023
@rfan1 rfan1 force-pushed the ci_yamllint branch 26 times, most recently from 1fd7ed0 to 8199656 Compare February 14, 2023 09:47
@RoyCai7
Copy link
Contributor

RoyCai7 commented Feb 14, 2023

It looks like it works well. LGTM

@rfan1 rfan1 force-pushed the ci_yamllint branch 2 times, most recently from 80715af to eeec287 Compare February 14, 2023 12:00
@rfan1 rfan1 force-pushed the ci_yamllint branch 10 times, most recently from ffd01c2 to bf1aa6f Compare February 15, 2023 03:17
@rfan1 rfan1 changed the title [wip]hide pass log for yaml file checking Hide CI passed logs for yaml files checking Feb 15, 2023
@rfan1 rfan1 added qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them and removed WIP Work in progress labels Feb 15, 2023
grisu48
grisu48 reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions. Let's remove the unnecessary \ from the script!

tools/check_yaml Outdated Show resolved Hide resolved
tools/check_yaml Outdated Show resolved Hide resolved
@rfan1 rfan1 force-pushed the ci_yamllint branch 2 times, most recently from 9da3b76 to 55773d7 Compare February 15, 2023 09:45
grisu48
grisu48 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@foursixnine foursixnine merged commit 0ebe21a into os-autoinst:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b10n1k b10n1k b10n1k left review comments

@grisu48 grisu48 grisu48 approved these changes

Assignees
No one assigned
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them
Projects
None yet
Milestone
No milestone
5 participants
@rfan1 @RoyCai7 @b10n1k @grisu48 @foursixnine