lib/x11utils: Use Ctrl instead of Esc to show the lockscreen #16536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plasma 5.27 introduced that Esc turns the monitor off. With 5.27.2, it no longer causes the lockscreen UI to show, so we can't use it here anymore. Ctrl appears to work fine.
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
DimStar77
approved these changes
Mar 3, 2023
If necessary just an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plasma 5.27 introduced that Esc turns the monitor off. With 5.27.2, it no longer causes the lockscreen UI to show, so we can't use it here anymore. Ctrl appears to work fine.
Verification runs:
KDE Live: https://openqa.opensuse.org/tests/3154656
GNOME Live: https://openqa.opensuse.org/tests/3154657
Xfce Live: https://openqa.opensuse.org/tests/3154662
Any other VRs needed? The lxde and the otherDE tests apparently don't trigger the lockscreen.