Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ssh serial console alive and check kvm modules #16696

Merged
merged 1 commit into from Apr 4, 2023

Conversation

Julie-CAO
Copy link
Contributor

@Julie-CAO Julie-CAO commented Mar 24, 2023

@Julie-CAO Julie-CAO changed the title Set ssh serial console alive and check kvm modules [WIP]Set ssh serial console alive and check kvm modules Mar 24, 2023
@waynechen55
Copy link
Contributor

waynechen55 commented Mar 24, 2023

I think this verification run is convincing. It passed host_upgrade_step2_run which took around 2hrs.

For guest upgrade, I do not think these two test runs 1 and 2 are convincing as above, because I did not see a failure with these two machines recently (This does not mean issue comes from SUT machine). But setting this should does no harm anyway from my perspective. I think more verification runs with guest upgrade needed. @guoxuguang

@Julie-CAO Julie-CAO changed the title [WIP]Set ssh serial console alive and check kvm modules Set ssh serial console alive and check kvm modules Mar 28, 2023
@Julie-CAO
Copy link
Contributor Author

@alice-suse @xguo @waynechen55 @nanzhg @tbaev @RoyCai7 @varunkojha @tonyyuan1 Welcome review!

@waynechen55
Copy link
Contributor

I am verifying guest upgrade with your branch

# use console based on ssh to avoid unstable ipmi
use_ssh_serial_console;
# double-check xen role for xen host
double_check_xen_role if (is_xen_host and !get_var('REBOOT_AFTER_UPGRADE'));
check_kvm_modules if is_kvm_host and !get_var('REBOOT_AFTER_UPGRADE');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok for s390 or arm tests? @guoxuguang @waynechen55

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM64 does not have KVM module because KVM module is either intel_kvm or amd_kvm I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll skip arm and s390 machines.

@waynechen55
Copy link
Contributor

I did several verification runs for guest upgrade. I think the result is convincing.

Although Test Run 1 failed, but it passed wait_serial step judging by serial0.txt and autoinst-log.txt: [2023-03-28T13:07:07.945335+02:00] [debug] [pid:338304] >>> testapi::wait_serial: CMD_FINISHED-519058: ok
Also Test Run 2: [2023-03-28T13:07:07.954561+02:00] [debug] [pid:339531] >>> testapi::wait_serial: CMD_FINISHED-469118: ok.

@waynechen55
Copy link
Contributor

waynechen55 commented Mar 30, 2023

In order to increase certainty, I think you can add one more checking in set_ssh_console_time in lib/Utils/Backend.pm like this:

if (script_run("ls $sshd_config_fle") == 0) {
    seting keepalive cofig
}
else {
    record_info
}

@Julie-CAO

@Julie-CAO
Copy link
Contributor Author

In order to increase certainty, I think you can add one more checking in set_ssh_console_time in lib/Utils/Backend.pm like this:

if (script_run("ls $sshd_config_fle") == 0) {
    seting keepalive cofig
}
else {
    record_info
}

@Julie-CAO

I agree.

@Julie-CAO Julie-CAO force-pushed the julie/kvm branch 2 times, most recently from 4d45068 to 1c7406f Compare April 3, 2023 05:54
@Julie-CAO
Copy link
Contributor Author

Add record_info and two more verification runs:
gi-guest_developing-on-host_developing-kvm
uefi-gi-guest_sles12sp5-on-host_developing-xen

PR is ready to merge.

@alice-suse alice-suse merged commit efcc3a1 into os-autoinst:master Apr 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants