New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ssh serial console alive and check kvm modules #16696
Conversation
I think this verification run is convincing. It passed host_upgrade_step2_run which took around 2hrs. For guest upgrade, I do not think these two test runs 1 and 2 are convincing as above, because I did not see a failure with these two machines recently (This does not mean issue comes from SUT machine). But setting this should does no harm anyway from my perspective. I think more verification runs with guest upgrade needed. @guoxuguang |
@alice-suse @xguo @waynechen55 @nanzhg @tbaev @RoyCai7 @varunkojha @tonyyuan1 Welcome review! |
I am verifying guest upgrade with your branch |
tests/virt_autotest/login_console.pm
Outdated
# use console based on ssh to avoid unstable ipmi | ||
use_ssh_serial_console; | ||
# double-check xen role for xen host | ||
double_check_xen_role if (is_xen_host and !get_var('REBOOT_AFTER_UPGRADE')); | ||
check_kvm_modules if is_kvm_host and !get_var('REBOOT_AFTER_UPGRADE'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok for s390 or arm tests? @guoxuguang @waynechen55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARM64 does not have KVM module because KVM module is either intel_kvm or amd_kvm I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll skip arm and s390 machines.
I did several verification runs for guest upgrade. I think the result is convincing. Although Test Run 1 failed, but it passed wait_serial step judging by serial0.txt and autoinst-log.txt: |
In order to increase certainty, I think you can add one more checking in
|
I agree. |
4d45068
to
1c7406f
Compare
Add record_info and two more verification runs: PR is ready to merge. |
check kvm modules to avoid the case happens again: bsc#1209596
keep ssh serial console always alive to get test output after a long run
Verification run:
host_upgrade from Wayne
guest-migration-developing-from-developing-to-developing-kvm //2.5 hours for guest migration. It should be convincing.