Test to install and verify kea dhcp4 server container #16736
Conversation
DeepthiYV
changed the title
|
Why not run in serial_terminal ? |
data/kea-dhcp/kea-dhcp4.conf
Outdated
| // else. | ||
| { | ||
| "hw-address": "1a:1b:1c:1d:1e:1f", | ||
| "ip-address": "10.0.2.201" | ||
| }, |
There was a problem hiding this comment.
I don't think this part is tested [along with the ones after]
MAC/DUID/CLIENTID etc
Can we mask them if possible? but it is not a bit deal.
| use lockapi; | ||
| use mmapi; | ||
| use mm_network 'setup_static_mm_network'; | ||
| use repo_tools 'add_qa_head_repo'; |
data/kea-dhcp/kea-dhcp4.conf
Outdated
| @@ -0,0 +1,461 @@ | |||
| // This is a basic configuration for the Kea DHCPv4 server. Subnet declarations | |||
There was a problem hiding this comment.
No hard requirement, but I would crop the config file down to the required settings and refer to https://kea.readthedocs.io for more details. That gives us a better overview about the USED settings in the test run, as opposed to show all POSSIBLE settings.
But I guess that's more of a style question, so I leave it to you to decide if you like that or not.
| @@ -29,7 +29,7 @@ sub run { | |||
| shift->wait_boot(bootloader_time => 300); | |||
| } | |||
| microos_login; | |||
| record_kernel_audit_messages(log_upload => 1); | |||
| record_kernel_audit_messages(log_upload => 1) unless (get_var('NICTYPE') eq 'tap'); | |||
There was a problem hiding this comment.
Why are we skipping this step? Is it failing?
If so, please add a comment so that our future selves will remember 🙂
| my ($self) = @_; | ||
| mutex_wait 'barrier_setup_done'; | ||
|
|
||
| assert_script_run("ip a"); |
There was a problem hiding this comment.
Is this necessary or does this provide debugging information? If the later, consider using record_info instead, e.g.
record_info("ip a", script_output("ip a"));
|
Please update VRs |
Updated latest VRs above. |
Add a multi-machine test to install and verify the ISC Kea DHCP4 server.
Latest VRs:
setup_dhcp4_server | DHCP4_client