Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover year_2038_detection test on TW and Micro-OS #16817

Merged
merged 1 commit into from Apr 18, 2023
Merged

Cover year_2038_detection test on TW and Micro-OS #16817

merged 1 commit into from Apr 18, 2023

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Apr 7, 2023

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@rfan1 rfan1 added qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them WIP Work in progress labels Apr 7, 2023
grisu48
grisu48 reviewed Apr 7, 2023
View reviewed changes
Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor improvement suggestion, overall LGTM!

tests/console/year_2038_detection.pm Outdated Show resolved Hide resolved
tests/console/year_2038_detection.pm Outdated Show resolved Hide resolved
tests/console/year_2038_detection.pm Show resolved Hide resolved
@rfan1 rfan1 added Ready Ready for review and removed WIP Work in progress labels Apr 7, 2023
@rfan1 rfan1 merged commit 9a170b0 into os-autoinst:master Apr 18, 2023
7 checks passed
@DimStar77
Copy link
Contributor

https://openqa.opensuse.org/tests/3233646#step/year_2038_detection/39

this weirdly fails in TW/MicroOS - even though the VR linked in this PR seems to have passed

@rfan1
Copy link
Contributor Author

rfan1 commented Apr 19, 2023

https://openqa.opensuse.org/tests/3233646#step/year_2038_detection/39

this weirdly fails in TW/MicroOS - even though the VR linked in this PR seems to have passed

Thanks @DimStar77
https://progress.opensuse.org/issues/127970, I will take a look at this issue tomorrow. I need to double check if Selinux plays some role there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grisu48 grisu48 grisu48 left review comments

Assignees
No one assigned
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them Ready Ready for review
Projects
None yet
Milestone
No milestone
3 participants
@rfan1 @DimStar77 @grisu48