Simplify smt test #16824
Merged
Simplify smt test #16824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dzedro
commented
Apr 11, 2023
dzedro
commented
- Related ticket: https://progress.opensuse.org/issues/127328 https://gitlab.suse.de/qa-maintenance/qam-openqa-yml/-/merge_requests/501
- Verification run: https://openqa.suse.de/tests/10895074
-rename client1 test to just client
-use serial terminal -install some packages after smt setup in smt_client test -create barriers in smt_server_install and add barrier so server wait for client -change smt_server_install base so it does not require x11 at end of test -drop set-hostname in smt_server_install it's already done in setup_multimachine -drop smt server url setup not needed as the predefined does match -restart apache after setup otherwise server will not provide correct certificate to client -specify mirrorable smt repo SLES12-SP5-Updates, no need to print all repos -update maintainer https://progress.opensuse.org/issues/127328
dzedro
added
Ready
rfan1
reviewed
Apr 11, 2023
|
Great work! only one minor comment left, LGTM |
rfan1
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.