Handle java license popup during installation #16830
Conversation
sofiasyria
force-pushed
the
java_popup
branch
3 times, most recently
from
df08231
to
6371edc
Compare
| if ((get_var("SCC_ADDONS") =~ /legacy/) && (is_sle("=15-SP4"))) { | ||
| my $package_license_popup = $testapi::distri->get_accept_popup_controller(); | ||
| $package_license_popup->wait_accept_popup({ | ||
| timeout => 3000, |
There was a problem hiding this comment.
the confirm package popup happens intermediately, there is not need to have an explicit wait.
There was a problem hiding this comment.
I have tried it already without the wait and it failed. It doesn't appear immediately enough
There was a problem hiding this comment.
can you share the link? what is the timeout and how much needs in the slower arch? 3000 is too much, and we should not abuse of this mechanism of explicit wait. We even have another ticket partially for that reason, https://progress.opensuse.org/issues/125561 to not repeat that code over and over, but still is a corner-case-code.
There was a problem hiding this comment.
btw your runs are done in your machine, for timeout I would recommend OSD, we might find something funny...
There was a problem hiding this comment.
I am running some VRs on OSD now. For the failed runs without the timeout , it might be this one: http://falafel.suse.cz/tests/901#step/confirm_package_license/2 or it has disappeared.
There was a problem hiding this comment.
that is some other failure during your development, I don't think is needed extra wait, we already wait 2 mins iirc,
Can't call method "exist" on an undefined value
There was a problem hiding this comment.
ok you added to the ticket (just noticed), so I'm fine if we do in the follow-up.
|
|
||
| sub run { | ||
| # For SLE 15 SP4 tests that have the Legacy module added during instalaltion, there is | ||
| # additional licence popup that is handled by the following function. | ||
| if ((get_var("SCC_ADDONS") =~ /legacy/) && (is_sle("=15-SP4"))) { |
There was a problem hiding this comment.
we need a ticket to remove this condition:
the product part of the condition via our distribution pattern and the first part just passing as parameter to a future confirm_installation() method as we discussed in Slack.
There was a problem hiding this comment.
I will open a ticket for this, but can't say that I have full understanding of your solution proposal. You want this java popup to be handled inside the confirm_installation() which will receive some arguments and act accordingly? The conditions should be inside the library?
There was a problem hiding this comment.
Can you please, check here: https://progress.opensuse.org/issues/127529
There was a problem hiding this comment.
I rephrased a bit but you got the idea, thanks!
|
@sofiasyria we probably needs to add to the condition the case where we have minimal patterns: |
For SP4 there is an extra java license popup that breaks installation tests. This PR is adding a way to handle it in confirm_installation.pm
OSD: https://openqa.suse.de/tests/10902903#next_previous