New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALP test profile for automated installation of Bedrock #16927
Conversation
- Related tickets: https://progress.opensuse.org/issues/126857 (also included parts of): https://progress.opensuse.org/issues/127349 - Using `agama.auto` boot parameter to launch the automatic installation - Currently using a shell skript to execute agama commands
@@ -0,0 +1,10 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's create schedule/yam/
and not differenciate yet between opensuse or sle, we can see later how it goes, so :
schedule/yam/agama_auto
as discussed offline, with can use just auto
instead of autoinst
is shorter and in the right folder is well understood IMO.
--- | ||
name: agama_auto | ||
description: > | ||
First test for autoinstallation wit agama |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/wit/with/
Please don't call it first, just states what does in the description prepare blab, boot, perform auto-installation blablab.
sub run { | ||
|
||
assert_screen('alp-installer-ui', 120); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this lines in the middle of the commands.
use strict; | ||
use warnings; | ||
|
||
use testapi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to import only 'assert_screen' from testapi, not the whole one so we minimize the use of testapi as pattern.
@@ -0,0 +1,23 @@ | |||
## Copyright 2023 SUSE LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably we just need tests/yam/agama/auto.pm
for now or we plan to do more version of this, I guess this would represent some sort o general mechanism, but I would not discard it wouldn't the only one, up to you.
## Copyright 2023 SUSE LLC | ||
# SPDX-License-Identifier: GPL-2.0-or-later | ||
|
||
# Summary: First installation using D-Installer current CLI (only for development purpose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary needs to be updated
@@ -0,0 +1,19 @@ | |||
## Copyright 2023 SUSE LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't need a new test module, it can be implemented inside bootloader_start
we don't need additional method just for this, in fact the dud is resolved in similar way I think. We can add this for follow-up ticket.
description: > | ||
First test for autoinstallation wit agama | ||
vars: | ||
AGAMA_AUTO: yam/agama/auto/alp.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this to job group, so the same schedule could be reuse with different scripts.
|
||
sub run { | ||
|
||
assert_screen('alp-installer-ui', 120); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't call it "installer", The Installer is the sle/opensuse one, this has a unique name, Agama, I would just match "Agama" text on top:
https://openqa.opensuse.org/tests/3237762#step/auto/1
with agama-main-page
Besides it shouldn't appear alp, as the installer can install alp but also Leap and Micro OS, etc, same web UI for all those products, so better not be so specific with the needle name.
|
||
assert_screen('alp-installer-ui', 120); | ||
|
||
assert_screen('alp-installing', 60); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: agama-installing
|
||
assert_screen('alp-installing', 60); | ||
|
||
assert_screen('bedrock-login', 960); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to reuse for other products, we might just need welcome to
text in the needle and a needle 'welcome-to` to signal finalization of auto-installation, wdyt?
I will merge this, and as my comments are more related with code organization @lemon-suse volunteer to do it. |
Related tickets: https://progress.opensuse.org/issues/126857
(also included parts of): https://progress.opensuse.org/issues/127349
Needles: 3 new needles created with needle editor
Verification runs for aarch64 and x86_64 on O3
Using
agama.auto
boot parameter to launch the automatic installationCurrently using a shell skript to execute agama commands