Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shim for LTSS-ERICSSON #17027

Merged
merged 2 commits into from May 15, 2023
Merged

Fix shim for LTSS-ERICSSON #17027

merged 2 commits into from May 15, 2023

Conversation

dzedro
Copy link
Contributor

@dzedro dzedro commented May 9, 2023

@dzedro dzedro added the qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them label May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

Add custom repos and update grub2 before update repos to avoid shim
signature failures. This is already done in qam-minimal/install_update.pm
at begging to avoid grub2/shim failure. Update grub2 again after
ERICSSON & TERADATA repos are added which also have grub2/shim packages.

https://progress.opensuse.org/issues/128993
lib/qam.pm Outdated Show resolved Hide resolved
@dzedro dzedro added notready WIP Work in progress and removed Ready Ready for review labels May 12, 2023
@dzedro dzedro added Ready Ready for review and removed notready WIP Work in progress labels May 15, 2023
@dzedro
Copy link
Contributor Author

dzedro commented May 15, 2023

I rerun the test, it failed because the update is already released, but UEFI part was executed as expected.

@dzedro dzedro merged commit 5192c71 into os-autoinst:master May 15, 2023
7 checks passed
@dzedro dzedro deleted the shim branch May 15, 2023 11:21
@rfan1
Copy link
Contributor

rfan1 commented May 16, 2023

Hello @dzedro https://progress.opensuse.org/issues/129361, seems your changes impact tests on aarch64 platform.

@mloviska
Copy link
Contributor

Also sle-micro is impacted
https://openqa.suse.de/tests/overview?distri=sle-micro&version=5.1&build=20230515-1&groupid=420

@jlausuch
Copy link
Contributor

Can we quickly revert this and re-work it again?

@mloviska
Copy link
Contributor

Can we quickly revert this and re-work it again?

there is a fix already out there #17078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them Ready Ready for review
Projects
None yet
4 participants