Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set grub2 timeout to infinite #17035

Merged
merged 1 commit into from May 10, 2023
Merged

Set grub2 timeout to infinite #17035

merged 1 commit into from May 10, 2023

Conversation

dzedro
Copy link
Contributor

@dzedro dzedro commented May 10, 2023 •
edited

@dzedro dzedro added the qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them label May 10, 2023
@dzedro dzedro requested a review from rfan1 May 10, 2023 12:25
@czerw
Copy link
Contributor

czerw commented May 10, 2023

Will it cover also SLE 12 installation ?

@dzedro
Copy link
Contributor Author

dzedro commented May 10, 2023

Will it cover also SLE 12 installation ?

Ye, I noticed it when I was looking for VRs to run.

czerw
czerw approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@czerw czerw left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on

@czerw czerw merged commit 665921d into os-autoinst:master May 10, 2023
7 checks passed
@dzedro dzedro deleted the grub2_timeout branch May 10, 2023 14:14
rfan1
rfan1 reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rfan1
Copy link
Contributor

rfan1 commented May 11, 2023

Thanks much for your quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfan1 rfan1 rfan1 left review comments

@foursixnine foursixnine foursixnine approved these changes

@czerw czerw czerw approved these changes

Assignees
No one assigned
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them
Projects
None yet
Milestone
No milestone
4 participants
@dzedro @czerw @rfan1 @foursixnine