Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pipe output into a pager for wicked service #17050

Merged
merged 1 commit into from May 18, 2023
Merged

Do not pipe output into a pager for wicked service #17050

merged 1 commit into from May 18, 2023

Conversation

tinawang123
Copy link
Contributor

@tinawang123 tinawang123 commented May 11, 2023 •
edited

Do not pipe output into a pager for wicked service

@rakoenig
Copy link
Contributor

LGTM.

chcao
chcao approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@chcao chcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinawang123 tinawang123 force-pushed the wicked branch 2 times, most recently from 8006b85 to 326ee99 Compare May 17, 2023 01:12
@jknphy jknphy merged commit b5b4713 into os-autoinst:master May 18, 2023
7 checks passed
@rfan1
Copy link
Contributor

rfan1 commented May 18, 2023

@tinawang123 seems your change causes failure at leap test:
https://openqa.opensuse.org/tests/3299196#step/wicked/4

@jknphy
Copy link
Contributor

jknphy commented May 18, 2023 •
edited

@tinawang123 seems your change causes failure at leap test: https://openqa.opensuse.org/tests/3299196#step/wicked/4

for a dead service the command return '3' and when using the library we need to ignore failures to have similar behavior that enter_cmd. Could you please @tinawang123 do this adjustment?
As recommended, @tinawang123 it is always good practice to read the code of the function libraries we use.

@dzedro dzedro mentioned this pull request May 18, 2023
Merged
@tinawang123 tinawang123 deleted the wicked branch May 19, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jknphy jknphy jknphy left review comments

@lemon-suse lemon-suse lemon-suse left review comments

@chcao chcao chcao approved these changes

Assignees

@chcao chcao

Labels
qe-yam
Projects
None yet
Milestone
No milestone
6 participants
@tinawang123 @rakoenig @rfan1 @jknphy @chcao @lemon-suse