Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the files under lib/yam to lib/Yam #17253

Merged
merged 1 commit into from Jul 10, 2023

Conversation

chcao
Copy link
Contributor

@chcao chcao commented Jun 12, 2023

There are 'Yam' and 'yam' folders under /lib/, actually Yam is the correct one, so we need move files under /lib/yam to /lib/Yam.

@chcao chcao added the qe-yam label Jun 12, 2023
@chcao chcao force-pushed the move_files_from_yam_to_Yam branch from 5224990 to c3878ad Compare June 12, 2023 10:05
There are 'Yam' and 'yam' folders under /lib/, actually Yam is the
correct one, so we need move files under /lib/yam to /lib/Yam.
@chcao chcao requested a review from coolgw June 14, 2023 05:33
@coolgw
Copy link
Contributor

coolgw commented Jun 14, 2023

Is there any VR?

@lemon-suse
Copy link
Contributor

Please rebase the code. On latest code, there are only two files under /yam/agama
linux-zyts:/var/lib/openqa/tests/sle/lib/yam # ls agama/
agama_base.pm patch_agama_base.pm

@chcao
Copy link
Contributor Author

chcao commented Jun 16, 2023

Is there any VR?

No VR for this PR.

@chcao
Copy link
Contributor Author

chcao commented Jun 16, 2023

Please rebase the code. On latest code, there are only two files under /yam/agama linux-zyts:/var/lib/openqa/tests/sle/lib/yam # ls agama/ agama_base.pm patch_agama_base.pm

No need to rebase the code, see the files I changed, not all 4 files are under lib/yam, two of them are under tests/yam/agama/, these two files "use yam::agama", need to update them to "use Yam::agama" after I move the files to lib/Yam

@lemon-suse
Copy link
Contributor

Please rebase the code. On latest code, there are only two files under /yam/agama linux-zyts:/var/lib/openqa/tests/sle/lib/yam # ls agama/ agama_base.pm patch_agama_base.pm

No need to rebase the code, see the files I changed, not all 4 files are under lib/yam, two of them are under tests/yam/agama/, these two files "use yam::agama", need to update them to "use Yam::agama" after I move the files to lib/Yam

You need rebase since the two files(tests/yam/agama/auto.pm, tests/yam/agama/patch_agama.pm) are not there under lib/yam any more, make sense?

@lemon-suse
Copy link
Contributor

Please rebase the code. On latest code, there are only two files under /yam/agama linux-zyts:/var/lib/openqa/tests/sle/lib/yam # ls agama/ agama_base.pm patch_agama_base.pm

No need to rebase the code, see the files I changed, not all 4 files are under lib/yam, two of them are under tests/yam/agama/, these two files "use yam::agama", need to update them to "use Yam::agama" after I move the files to lib/Yam

You need rebase since the two files(tests/yam/agama/auto.pm, tests/yam/agama/patch_agama.pm) are not there under lib/yam any more, make sense?

Ok, the two files are test modules while not in the lib/yam folder.

Please rebase the code. On latest code, there are only two files under /yam/agama linux-zyts:/var/lib/openqa/tests/sle/lib/yam # ls agama/ agama_base.pm patch_agama_base.pm

No need to rebase the code, see the files I changed, not all 4 files are under lib/yam, two of them are under tests/yam/agama/, these two files "use yam::agama", need to update them to "use Yam::agama" after I move the files to lib/Yam

You need rebase since the two files(tests/yam/agama/auto.pm, tests/yam/agama/patch_agama.pm) are not there under lib/yam any more, make sense?

Ok, got it, the two files are test modules and not in lib/yam folder.

@lemon-suse
Copy link
Contributor

It's better to run a VR for it,

@chcao
Copy link
Contributor Author

chcao commented Jun 19, 2023

It's better to run a VR for it,

I run the VR.

@chcao
Copy link
Contributor Author

chcao commented Jun 19, 2023

Is there any VR?

I run the VR for this.

@chcao chcao requested a review from JRivrain June 27, 2023 07:36
@lemon-suse lemon-suse merged commit ad24916 into os-autoinst:master Jul 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants