Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use default iface 'ovs-system' on xen setup #17291

Merged
merged 1 commit into from Jun 21, 2023

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Jun 20, 2023

@rfan1
Copy link
Contributor Author

rfan1 commented Jun 20, 2023

@alice-suse
May I ask for your kindly review since the code changes are for xen hypervisor?

@alice-suse
Copy link
Contributor

@nanzhg Nan is mostly involved in svirt backend for VT test. Would you like to give it a review ?

@rfan1 rfan1 added the qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them label Jun 20, 2023
@nicksinger
Copy link
Member

Why is 'ovs-system' in "bridges" in the first place? Is this some default from virsh? Otherwise it looks fine for me - I just wonder if we layer multiple workarounds on top of each other now

Copy link
Contributor

@dzedro dzedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The worker network setup is somehow wild, I would imagine to have generic default working worker network setup, without need of this additional configuration.

@rfan1
Copy link
Contributor Author

rfan1 commented Jun 20, 2023

Why is 'ovs-system' in "bridges" in the first place? Is this some default from virsh? Otherwise it looks fine for me - I just wonder if we layer multiple workarounds on top of each other now

I would say the ovs-system is the default one on xen server. however, I don't know the background why we used 'br0' as source bridge to build VMs.
based on QA testing purpose, seems we have worked for a long time with br0

@rfan1
Copy link
Contributor Author

rfan1 commented Jun 20, 2023

The worker network setup is somehow wild, I would imagine to have generic default working worker network setup, without need of this additional configuration.

I agree with you on this point, once we have a dedicated source bridge to carry out the tests, it is easy. :)

@nanzhg
Copy link
Contributor

nanzhg commented Jun 21, 2023

LGTM. Still a question, from the job title "sle-15-SP5-JeOS-for-kvm-and-xen-Updates-x86_64-Buildrfan0619-xen_ovs-system@svirt-xen-hvm", it's related to test ovs-system on Xen, but I can't see this test cover ovs-system iface. So what's the aim of this test?

@rfan1
Copy link
Contributor Author

rfan1 commented Jun 21, 2023

LGTM. Still a question, from the job title "sle-15-SP5-JeOS-for-kvm-and-xen-Updates-x86_64-Buildrfan0619-xen_ovs-system@svirt-xen-hvm", it's related to test ovs-system on Xen, but I can't see this test cover ovs-system iface. So what's the aim of this test?

I cloned the failed to job to run this VR to make sure my code changes can work. :) , it was not intend to test ovs-system:

openqa-clone-job --from http://openqa.suse.de --host http://openqa.suse.de 11390499 _GROUP_ID=0 -skip-download --skip-chained-deps BUILD=rfan0619 TEST=xen_ovs-system NOLOGS=1 RETRY=0 CASEDIR=https://github.com/rfan1/os-autoinst-distri-opensuse.git#xen_ovs-system

@rfan1 rfan1 merged commit f0629c9 into os-autoinst:master Jun 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them
Projects
None yet
5 participants