Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

susedistribution: bootloader_setup: Add user-sut-serial #17306

Merged
merged 2 commits into from Jul 7, 2023
Merged

susedistribution: bootloader_setup: Add user-sut-serial #17306

merged 2 commits into from Jul 7, 2023

Conversation

pevik
Copy link
Contributor

@pevik pevik commented Jun 22, 2023 •
edited

user-serial is svirt serial console for user. Adding a link helps switching between root and non root user in select_serial_terminal(). This commit is similar to 4a89bfb.

Verification run:
with updated os-autoinst os-autoinst/os-autoinst#2330 (API version 39)

Ticket: poo#131258

NOTE: WIP is due waiting API version 39 being installed to all workers.

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@pevik
Copy link
Contributor Author

pevik commented Jun 22, 2023

@dzedro FYI

@pevik pevik changed the title susedistribution: bootloader_setup: Add sut-serial [WIP] susedistribution: bootloader_setup: Add sut-serial Jun 22, 2023
@pevik pevik force-pushed the sut-serial-for-user branch 2 times, most recently from 80414a2 to d270b83 Compare June 23, 2023 10:54
@pevik pevik mentioned this pull request Jun 23, 2023
Merged
@pevik pevik force-pushed the sut-serial-for-user branch 4 times, most recently from 38017a9 to 4e312c6 Compare June 26, 2023 10:34
pevik
pevik commented Jun 26, 2023
View reviewed changes
lib/bootloader_setup.pm Outdated Show resolved Hide resolved
pevik
pevik commented Jun 26, 2023
View reviewed changes
lib/susedistribution.pm Outdated Show resolved Hide resolved
@pevik pevik force-pushed the sut-serial-for-user branch 2 times, most recently from e36545d to 10bd246 Compare June 26, 2023 22:24
@pevik
Copy link
Contributor Author

pevik commented Jun 27, 2023

@dzedro The failure in isotovideo main: "SERIAL_USER_TERMINAL_DEFAULT_DEVICE" is not exported by the backend::svirt module means that CI is using old os-autoinst. I wonder when it's going to be updated.

@pevik pevik mentioned this pull request Jun 27, 2023
Merged
@pevik pevik force-pushed the sut-serial-for-user branch 3 times, most recently from 64584ad to 2ec3ea8 Compare July 4, 2023 18:41
dzedro
dzedro reviewed Jul 4, 2023
View reviewed changes
lib/susedistribution.pm Outdated Show resolved Hide resolved
@pevik
Copy link
Contributor Author

pevik commented Jul 4, 2023

It looks like the problem was solved after I rebased. Therefore testing in https://openqa.opensuse.org/tests/overview?build=sut-serial-for-user and https://openqa.suse.de/tests/overview?build=sut-serial-for-user.

pevik added 2 commits July 6, 2023 20:56
@pevik
select_serial_terminal: Rename sut-serial for user
98cbe62 
ca57fae wrongly named sut-serial console for user just 'sut-serial',
rename it for consistency 'user-sut-serial'.

Console has not been added, thus it should affect anything.

Fixes: ca57fae ("select_serial_terminal: Make use of root-sut-serial")
Reported-by: Jozef Pupava <jpupava@suse.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
@pevik
susedistribution: bootloader_setup: Add user-sut-serial
c1e4fd3 
Add user-sut-serial - ssh-virtsh-serial console for user.

ssh-virtsh-serial is svirt serial console for user. Adding a link helps
switching between root and non root user in select_serial_terminal().

This commit is similar to 4a89bfb ("susedistribution: Run user virtio
console on it's own socket").

This requires API version 39, merged in
os-autoinst/os-autoinst#2330

NOTE: guarders if (isotovideo::get_version() >= 39) aren't used,
because they trigger warnings "Use of uninitialized value in numeric
ge (>=)" on imports (outside of functions).

Implements: poo#131258
Signed-off-by: Petr Vorel <pvorel@suse.cz>
@pevik pevik mentioned this pull request Jul 6, 2023
Merged
@pevik pevik changed the title [WIP] susedistribution: bootloader_setup: Add sut-serial [WIP] susedistribution: bootloader_setup: Add user-sut-serial Jul 6, 2023
@pevik
Copy link
Contributor Author

pevik commented Jul 7, 2023

@dzedro IMHO it's working now(e.g. https://openqa.suse.de/tests/11529483#step/zypper_lifecycle/1 and others), thus I could remove WIP, so that it could be merged. WDYT?
I also need to upload serial_terminal_user.txt, but that can be a separate effort (in different git repository anyway).

@dzedro
Copy link
Contributor

dzedro commented Jul 7, 2023

@dzedro IMHO it's working now(e.g. https://openqa.suse.de/tests/11529483#step/zypper_lifecycle/1 and others), thus I could remove WIP, so that it could be merged. WDYT? I also need to upload serial_terminal_user.txt, but that can be a separate effort (in different git repository anyway).

I agree, let's merge this.

@pevik pevik changed the title [WIP] susedistribution: bootloader_setup: Add user-sut-serial susedistribution: bootloader_setup: Add user-sut-serial Jul 7, 2023
@pevik pevik merged commit cf8e583 into os-autoinst:master Jul 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzedro dzedro dzedro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pevik @dzedro