Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all the autoyast profiles from Migration job groups to data/yam/ #17339

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Move all the autoyast profiles from Migration job groups to data/yam/ #17339

merged 1 commit into from
Jul 21, 2023

Conversation

hjluo
Copy link
Contributor

@hjluo hjluo commented Jun 30, 2023 •
edited
Loading

  • Description
    Move all the autoyast profiles from Migration job groups to data/yam/

  • Related ticket:

  • Related MR:

  • Needles: N/A

  • Verification run:

@hjluo hjluo force-pushed the move_autoyast_profile branch 2 times, most recently from 4c980c2 to 0f9f9e2 Compare July 5, 2023 04:12
@hjluo hjluo added the qe-yam label Jul 7, 2023
@hjluo hjluo changed the title [WIP]:Move all the autoyast profiles from Migration job groups to data/yam/ Move all the autoyast profiles from Migration job groups to data/yam/ Jul 7, 2023
@lemon-suse
Copy link
Contributor

lemon-suse commented Jul 7, 2023 •
edited
Loading

We should move these autoyast profile in MU-dev job group for migration support image to data/yam also.

Thought a while, these should be put in your another PR for support images.

@lemon-suse
Copy link
Contributor

It seems you missed the autoyast_sle15/autoyast_scc_up_ppc64le.xml in https://openqa.nue.suse.com/tests/11164722#settings

And please double check migration job groups for autoyast profile used. Thanks.

@hjluo
Copy link
Contributor Author

hjluo commented Jul 7, 2023

We should move these autoyast profile in MU-dev job group for migration support image to data/yam also.

Thought a while, these should be put in your another PR for support images.

OK, thank you.

lemon-suse
lemon-suse reviewed Jul 10, 2023
View reviewed changes
data/yam/create_hdd_gnome_allpatterns_aarch64.xml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these installation profile prepared for migration, we'd better to make them in another PR for support_images and move to data/yast/support_image/.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed and please take a look again. Thank you

@hjluo hjluo changed the title Move all the autoyast profiles from Migration job groups to data/yam/ WIP:Move all the autoyast profiles from Migration job groups to data/yam/ Jul 10, 2023
@hjluo hjluo force-pushed the move_autoyast_profile branch 5 times, most recently from 5e5d1e3 to f498bd5 Compare July 10, 2023 06:00
@lemon-suse
Copy link
Contributor

Refer to PR #17352, we should move these profiles to data/yam/autoyast/.

@hjluo
Copy link
Contributor Author

hjluo commented Jul 12, 2023 •
edited
Loading

Refer to PR #17352, we should move these profiles to data/yam/autoyast/.

OK, thank you, @jknphy, just want to make sure that for migration, we need to move all migration-related autoyast profiles to data/yam/autoyast ? thank you

@hjluo hjluo changed the title WIP:Move all the autoyast profiles from Migration job groups to data/yam/ Move all the autoyast profiles from Migration job groups to data/yam/ Jul 12, 2023
@jknphy
Copy link
Contributor

jknphy commented Jul 12, 2023

Refer to PR #17352, we should move these profiles to data/yam/autoyast/.

OK, thank you, @jknphy, just want to make sure that for migration, we need to move all migration-related autoyast profiles to data/yam/autoyast ? thank you

yes, that is the folder.
regarding the files that are in this PR, looks like they are for creation of images, or those are used for migration?
there should be a easy way to distinguish migration from installation easly by the name, please think about that.

@hjluo hjluo changed the title Move all the autoyast profiles from Migration job groups to data/yam/ WIP:Move all the autoyast profiles from Migration job groups to data/yam/ Jul 13, 2023
@hjluo
Copy link
Contributor Author

hjluo commented Jul 13, 2023

Refer to PR #17352, we should move these profiles to data/yam/autoyast/.

OK, thank you, @jknphy, just want to make sure that for migration, we need to move all migration-related autoyast profiles to data/yam/autoyast ? thank you

yes, that is the folder. regarding the files that are in this PR, looks like they are for creation of images, or those are used for migration? there should be a easy way to distinguish migration from installation easly by the name, please think about that.

changed and thank you.

@hjluo hjluo changed the title WIP:Move all the autoyast profiles from Migration job groups to data/yam/ Move all the autoyast profiles from Migration job groups to data/yam/ Jul 13, 2023
@lemon-suse
Copy link
Contributor

It seems you move all the profile to data/yam/autoyast/, but we should distinguish them from profile for migration or profile for installation for support images, for migration we should move to data/yam/autoyast/, for support images then move to data/yam/autoyast/support_images/.

@hjluo
Copy link
Contributor Author

hjluo commented Jul 19, 2023

It seems you move all the profile to data/yam/autoyast/, but we should distinguish them from profile for migration or profile for installation for support images, for migration we should move to data/yam/autoyast/, for support images then move to data/yam/autoyast/support_images/.

OK, I'd change them based on their names and rerun all the VRs to make sure they still work.

@hjluo hjluo changed the title Move all the autoyast profiles from Migration job groups to data/yam/ WIP:Move all the autoyast profiles from Migration job groups to data/yam/WIP: Jul 19, 2023
@hjluo hjluo changed the title WIP:Move all the autoyast profiles from Migration job groups to data/yam/WIP: Move all the autoyast profiles from Migration job groups to data/yam/WIP: Jul 21, 2023
lemon-suse
lemon-suse reviewed Jul 21, 2023
View reviewed changes
data/yam/support_images/create_hdd_gnome_allpatterns_aarch64.xml
Copy link
Contributor

@lemon-suse lemon-suse Jul 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, the folder of autoyast_sle15/create_hdd owned by functional squad, we should copy profiles from this folder to yam/autoyast/support_images while not move.(It's better to change the name) Same for below other profiles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lemon-suse @jknphy so can you please help me to revert it?

@jknphy jknphy changed the title Move all the autoyast profiles from Migration job groups to data/yam/WIP: Move all the autoyast profiles from Migration job groups to data/yam/ Jul 21, 2023
@jknphy jknphy merged commit d60b0cd into os-autoinst:master Jul 21, 2023
7 checks passed
@lemon-suse lemon-suse mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemon-suse lemon-suse lemon-suse left review comments

Assignees

@rakoenig rakoenig

@lemon-suse lemon-suse

Labels
qe-yam
Projects
None yet
Milestone
No milestone
4 participants
@hjluo @lemon-suse @jknphy @rakoenig