Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bsc#1213635 soft-failure for salt test #17483

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

DeepthiYV
Copy link
Contributor

@DeepthiYV DeepthiYV commented Jul 25, 2023

Latest VRs:

salt_master | salt_minion

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@DeepthiYV DeepthiYV requested a review from rfan1 July 25, 2023 12:41
@DeepthiYV DeepthiYV marked this pull request as draft July 25, 2023 13:16
lib/saltbase.pm Show resolved Hide resolved
@rfan1
Copy link
Contributor

rfan1 commented Jul 27, 2023

LGTM, can you please add new VR?

@DeepthiYV DeepthiYV requested a review from rfan1 July 27, 2023 08:13
@dzedro dzedro marked this pull request as ready for review July 27, 2023 08:21
Copy link
Contributor

@dzedro dzedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why add softfail_flag ? It will just add another 2 lines and do the same, but whatever.
Keep it simple ...

@rfan1 rfan1 merged commit 9e6f73d into os-autoinst:master Jul 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants