Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scroll direction to fix assert_and_click for openqa test #17526

Merged
merged 1 commit into from Aug 4, 2023

Conversation

Zaoliang
Copy link
Contributor

@Zaoliang Zaoliang commented Aug 3, 2023

sendkey 'end' is wrong because the next needle match(click_lastmatch) doesn't work reliable because in the running test is covered a little bit.
So change scroll page direction can help and adding timeout as well.
See https://progress.opensuse.org/issues/133718

@Zaoliang Zaoliang force-pushed the test-results-2023 branch 6 times, most recently from 289a37a to 064d6a8 Compare August 3, 2023 09:09
@Zaoliang Zaoliang changed the title WIP Add timeout for assert_and_click for openqa test WIP Repeat assert_and_click for openqa test Aug 3, 2023
@Zaoliang Zaoliang force-pushed the test-results-2023 branch 2 times, most recently from 79d0ffa to b3f4089 Compare August 3, 2023 10:10
I found out why the test failed. sendkey 'end' is wrong because the next needle match doesn't work reliable because the running test is covered a little bit.

So change scroll page direction can help and add timeout as well.
See https://progress.opensuse.org/issues/133718
@Zaoliang
Copy link
Contributor Author

Zaoliang commented Aug 3, 2023

https://openqa.opensuse.org/tests/3479158#next_previous shows now successful test runs.

@Zaoliang Zaoliang changed the title WIP Repeat assert_and_click for openqa test Change scroll direction to fix assert_and_click for openqa test Aug 3, 2023
@Zaoliang Zaoliang merged commit e51804e into os-autoinst:master Aug 4, 2023
7 checks passed
@Zaoliang Zaoliang deleted the test-results-2023 branch August 4, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant