Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new workaround for nvidia repo not reliable with new hot-key #17610

Merged
merged 1 commit into from Aug 22, 2023

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Aug 21, 2023

https://progress.opensuse.org/issues/134423
https://bugzilla.suse.com/show_bug.cgi?id=1214234

Based on the test result, the workaround can not work perfectly on sled tests, we may need to file a new ticket.

@rfan1 rfan1 requested a review from dzedro August 21, 2023 03:41
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@rfan1 rfan1 requested a review from foursixnine August 21, 2023 03:41
Copy link
Member

@foursixnine foursixnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may result in this failing in older sp's if they are still using old installer, but I doubt that they will face the problem as the nvidia repos are already present for released products

@rfan1
Copy link
Contributor Author

rfan1 commented Aug 21, 2023

This may result in this failing in older sp's if they are still using old installer, but I doubt that they will face the problem as the nvidia repos are already present for released products

Thanks, you are correct, I noticed that autoyast uses the same workaround

autoyast/installation.pm

    elsif (match_has_tag('nvidia-validation-failed')) {
        # nvidia repositories are unstable and really not needed for anything
        record_info("NVIDIA", "NVIDIA repository is broken");
        wait_still_screen { send_key 'alt-o' };
        send_key 'alt-n';
        $num_errors++;
    }

@rfan1 rfan1 merged commit 2a665bd into os-autoinst:master Aug 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants