Enable logs upload for agama playwright tests

[manfredi]

• Description: Enable logs upload for agama playwright tests
• Related ticket: https://progress.opensuse.org/issues/134690
• Verification run: overview

[rakoenig]

LGTM, so we have a tarball with all the traces.zip in their individual directories in it. Saves us from some headaches when we design tests.

[jknphy]

Looks good, please move all this code to agama_base. I can see that it needs to happen before the reboot, so we need some test module in perl that does that, is there any existing one, if not, we can create it. reboot should not be part of the agama process as we can trigger it in different ways actually.

[manfredi]

Code moved inside lib/Yam/agama/agama_base.pm

[jknphy]

could you check why this doesn't work for you?
tar_and_upload_log()
actually it would be better not to use assert_script_run and use script_run, otherwise you never get logs of other thing you try to get log below this point, the function on top probably do not use either.

[manfredi]

Inside the ISO it seems that bzip2 is not present: bzip2: command not found.
The sub tar_and_upload_log() use it to compress the tarball by using the options tar -jcv -f.

Modified the sub upload_traces(), so that continue in case of failure.

[jknphy]

we use for yast logs get_available_compression(), it happens in minimal system the same thing. It is quite hard to map a linux command with a wrapper, you never get exactly what you want if you just map its options "a little"like in this case, and if you map it fully, probably doesn't worth the effort for the given use, and it would better to do it with some cpan module, so it is kind doing bash in Perl what we are doing in the repo IMO.

We could update that function passing in $args the compression, but that would be just a letter "j" or "z" and that would not be very readable, as there are not enums in perl, we would need constants or passing the whole word (which something there isn't depending on the command arg of a given command) but you can add a comment in the documentation of the function describing both formats and that would help, it would be something like $args->{compression_options} which would take a default value of "j" to not break existing code.
what solution you prefer? we can go both ways.

dismissing review due to assert_script might avoid log recollection