Modify existing scenario agama_auto_dolomite for selecting another installation device #17719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinawang123
force-pushed
the
selectdev
branch
from
1587820
to
7a8de17
Compare
tinawang123
force-pushed
the
selectdev
branch
from
7a8de17
to
7b3f403
Compare
|
I can see the second HDD image in your job setting, I would like suggest you adding it, and then use |
tinawang123
changed the title
tinawang123
force-pushed
the
selectdev
branch
3 times, most recently
from
a83a567
to
8d974a1
Compare
JRivrain
reviewed
Sep 7, 2023
| sub run { | ||
| select_console 'root-console'; | ||
|
|
||
| my $installed_disk_expected = get_test_suite_data()->{installed_disk}; |
There was a problem hiding this comment.
I think validate vda is not useful as its the default, so we don't know if the disk was selected thanks to the jsonnet code, or just because it's the default.
Please use a second disk, then you could try to use console/validate_first_disk_selection with this test data:
guided_partitioning:
disks:
- vdb
unused_disks:
- vda
There was a problem hiding this comment.
It already has 'console/validate_first_disk_selection' test module to check the disk.
I will delete this test module, use the existed one.
tinawang123
force-pushed
the
selectdev
branch
11 times, most recently
from
d181ec1
to
57e56ae
Compare
tinawang123
force-pushed
the
selectdev
branch
2 times, most recently
from
623057e
to
b394f00
Compare
tinawang123
changed the title
rfan1
reviewed
Sep 19, 2023
tinawang123
force-pushed
the
selectdev
branch
2 times, most recently
from
57cdc99
to
ba57661
Compare
tinawang123
force-pushed
the
selectdev
branch
2 times, most recently
from
0287dd6
to
83674d2
Compare
tinawang123
force-pushed
the
selectdev
branch
from
83674d2
to
17f8450
Compare
…stallation device
tinawang123
force-pushed
the
selectdev
branch
from
17f8450
to
055d5e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify existing scenario agama_auto_dolomite for selecting another installation device
https://openqa.opensuse.org/tests/3604383#