Add a ping check with MTU packet size #17799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please explain why do you do this? |
czerw
reviewed
Sep 21, 2023
| @@ -39,6 +39,8 @@ sub run { | |||
| # Set the hostname to identify both minions | |||
| set_hostname $hostname; | |||
|
|
|||
| # Perform ping to client from server | |||
| assert_script_run("ping -M do -c 1 -s 1430 10.0.2.102") if ($hostname =~ /server|master/); | |||
There was a problem hiding this comment.
@DeepthiYV PR #17817 was merged, you can reuse the function which was introduced there (either with multiple sizes check or with fixed size).
This check in the Multimachine job was intended to verify network performance by testing MTU. Now that I see the tests are stable, I don't think we need this pull request anymore. So, I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still doing Debugging