Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: Add support for transactional systems to update_kernel module #18012

Merged
merged 3 commits into from
Oct 24, 2023
Merged

kernel: Add support for transactional systems to update_kernel module #18012

merged 3 commits into from
Oct 24, 2023

Conversation

czerw
Copy link
Contributor

@czerw czerw commented Oct 18, 2023 •
edited
Loading

@czerw czerw requested a review from mdoucha October 18, 2023 07:44
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@czerw czerw force-pushed the sle-micro-maintenance branch 5 times, most recently from 15dc357 to 410423d Compare October 18, 2023 09:48
@czerw czerw removed the request for review from mdoucha October 18, 2023 09:52
@czerw czerw force-pushed the sle-micro-maintenance branch 7 times, most recently from f49acc0 to 11f1a3b Compare October 18, 2023 14:41
@mdoucha
Copy link
Contributor

mdoucha commented Oct 18, 2023 •
edited
Loading

verification run with SLE_PRODUCT=slert: https://openqa.suse.de/tests/12563972

pevik
pevik reviewed Oct 19, 2023
View reviewed changes
lib/utils.pm Outdated Show resolved Hide resolved
@czerw czerw changed the title [WIP] kernel: Skip grub match on transactional systems in update_kernel [WIP] kernel: Add support for transactional systems to update_kernel module Oct 19, 2023
czerw
czerw commented Oct 19, 2023
View reviewed changes
lib/utils.pm Show resolved Hide resolved
@czerw czerw force-pushed the sle-micro-maintenance branch 3 times, most recently from 4e5c7b1 to df06b63 Compare October 19, 2023 14:58
czerw
czerw commented Oct 19, 2023
View reviewed changes
lib/utils.pm Show resolved Hide resolved
czerw
czerw commented Oct 19, 2023
View reviewed changes
tests/kernel/update_kernel.pm Outdated Show resolved Hide resolved
czerw
czerw commented Oct 19, 2023
View reviewed changes
tests/kernel/update_kernel.pm Outdated Show resolved Hide resolved
@czerw
grub: Swap order of product matching for transactional systems
a6394cf 
ALP and SLE Micro menu conditions were moved before SLES and SLE-RT
products to avoid possible conflicts with kernel-rt installations.
@czerw czerw force-pushed the sle-micro-maintenance branch 2 times, most recently from 087edc5 to 9e25a57 Compare October 23, 2023 15:09
@czerw
Copy link
Contributor Author

czerw commented Oct 23, 2023

@foursixnine @dzedro FYI: This PR also touches fully_patch_system, which is core function for maintenance.

foursixnine
foursixnine reviewed Oct 23, 2023
View reviewed changes
tests/kernel/update_kernel.pm
Comment on lines +114 to +121
if (is_transactional) {
# Proceed with transactional-update patch
trup_call("patch");
# Reboot system after patch, to make sure that further checks are done on updated system
reboot_on_changes;
} else {
zypper_call("in -l -t patch $patches", exitcode => [0, 102, 103], log => 'zypper.log', timeout => 1400);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess instances of this is where the follow ups to https://progress.opensuse.org/issues/117028 are to be added, right?

something to note would be that patch is also something that has to be there too.

@fgerling Can you add a ticket to our backlog about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something to note would be that patch is also something that has to be there too.

I made comment in mentioned ticket regarding patch.

@czerw czerw changed the title [WIP] kernel: Add support for transactional systems to update_kernel module kernel: Add support for transactional systems to update_kernel module Oct 24, 2023
mdoucha
mdoucha approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mdoucha mdoucha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like SLE-Micro has no kernel-devel packages at all, not even for kernel-default. LGTM then.

pevik
pevik approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@pevik pevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are others more familiar with Alp.

@czerw czerw merged commit 1501176 into os-autoinst:master Oct 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foursixnine foursixnine foursixnine left review comments

@pevik pevik pevik approved these changes

@mdoucha mdoucha mdoucha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@czerw @mdoucha @foursixnine @pevik