Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force sles4sap/hana_cluster test module to run on serial terminal #18032

Merged
merged 3 commits into from Oct 20, 2023

Conversation

alvarocarvajald
Copy link
Contributor

@alvarocarvajald alvarocarvajald commented Oct 19, 2023

This PR has 2 purposes:

  1. Force fencing module to run in root-console: Usually, ha/fencing module is followed by boot/boot_to_desktop, which checks first for a grub screen. In this commit we force fencing module to run in the root-console, so the node reboot goes directly from the console to grub, even on systems installed with gnome. If not doing this, systems installed with gnome will go the long way around of attempting to match the grub needle on the displaymanager and fail after a timeout. This is required because of the 2nd item below.
  2. Run HANA nodes on QEMU with VIRTIO_CONSOLE=1: To force the tests to use serial console and not the root console which is slower.

Usually, `ha/fencing` module is followed by `boot/boot_to_desktop`,
which checks first for a grub screen. In this commit we force fencing
module to run in the root-console, so the node reboot goes directly from
the console to grub, even on systems installed with gnome. If not doing
this, systems installed with gnome will go the long way around of
attempting to match the grub needle on the displaymanager and fail after
a timeout.
To force the tests to use serial console and not the root console which
is slower.
@emiura
Copy link
Contributor

emiura commented Oct 19, 2023

LGTM

@alvarocarvajald
Copy link
Contributor Author

Added verification runs for both YAML schedules, and for HA tests on qemu & svirt to see if the changes in ha/fencing break them. Let me know if we should add another VR

Copy link
Contributor

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alvarocarvajald
Copy link
Contributor Author

All qemu VRs passed. svirt (s390x) VRs are still pending.

@alvarocarvajald
Copy link
Contributor Author

alvarocarvajald commented Oct 20, 2023

s903x jobs failed in an unrelated issue (before fencing module). Seems to be a race condition in the vg module, as it tries to check for a cluster resource that is in Starting (not Started) status. I will push more changes to this, so I'll re-request your review once I'm done.

@alvarocarvajald
Copy link
Contributor Author

alvarocarvajald commented Oct 20, 2023

Pushed a small change to the ha/vg test module to fix the failing VR for s390x. Re-running HA regression VRs.

@alvarocarvajald alvarocarvajald removed the WIP Work in progress label Oct 20, 2023
@alvarocarvajald
Copy link
Contributor Author

s390x VRs passed. Merging this. Hopefully no hana_cluster failures next week.

@alvarocarvajald alvarocarvajald merged commit a661592 into os-autoinst:master Oct 20, 2023
7 checks passed
@alvarocarvajald alvarocarvajald deleted the team8684 branch October 20, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants