Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a new test for python-beautifulsoup4 #18045

Merged
merged 1 commit into from Nov 3, 2023
Merged

Introduce a new test for python-beautifulsoup4 #18045

merged 1 commit into from Nov 3, 2023

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Oct 23, 2023 •
edited

@ilmanzo ilmanzo force-pushed the poo138095_beautifulsoup4 branch 2 times, most recently from c593896 to 70e944e Compare October 23, 2023 08:17
@ilmanzo ilmanzo added the qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them label Oct 23, 2023
@ilmanzo ilmanzo changed the title Introduce a new test for Python-BeautifulSoup4 Introduce a new test for python-beautifulsoup4 Oct 23, 2023
@ilmanzo ilmanzo marked this pull request as draft October 25, 2023 07:10
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@ilmanzo ilmanzo force-pushed the poo138095_beautifulsoup4 branch 17 times, most recently from 41f61f3 to 9fb6dd5 Compare October 26, 2023 12:19
@ilmanzo ilmanzo marked this pull request as ready for review October 26, 2023 12:43
foursixnine
foursixnine requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@foursixnine foursixnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looksl ike you're doing some nice refactoring, there are other modules that are having similar code

Also specially the python_version_utils needs to be in the commit message (I would suggest to split the change)

tests/console/python3_beautifulsoup4.pm Show resolved Hide resolved
@ilmanzo ilmanzo force-pushed the poo138095_beautifulsoup4 branch 4 times, most recently from fdab647 to fb32994 Compare November 3, 2023 13:14
@ilmanzo
Introduce a new test for Python-BeautifulSoup4
c5fecc3 
provide also python_version_utils.pm for shared common python functions
foursixnine
foursixnine reviewed Nov 3, 2023
View reviewed changes
tests/console/python3_beautifulsoup4.pm
Comment on lines +34 to +36
return unless script_run("zypper search $python_package-beautifulsoup4") == 0;
record_info("Testing for $python_package");
zypper_call("install $python_package $python_package-beautifulsoup4 $python_package-lxml");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart :)

@ilmanzo ilmanzo merged commit 356efa7 into os-autoinst:master Nov 3, 2023
8 checks passed
@ilmanzo ilmanzo deleted the poo138095_beautifulsoup4 branch November 3, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepthiYV DeepthiYV DeepthiYV left review comments

@foursixnine foursixnine foursixnine approved these changes

Assignees
No one assigned
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them
Projects
None yet
Milestone
No milestone
3 participants
@ilmanzo @foursixnine @DeepthiYV