Xen PV VMs are without usb #18058
Merged
Xen PV VMs are without usb #18058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`/dev/bus/` is missing in Xen PV VMs as we do not create VMs with usb passthrough. - ticket: https://progress.opensuse.org/issues/135518
mloviska
requested review from
pdostal,
grisu48 and
ricardobranco777
as code owners
dzedro
approved these changes
Oct 24, 2023
ricardobranco777
approved these changes
Oct 24, 2023
| @@ -31,8 +32,10 @@ sub run { | |||
| record_info('Test', 'Launch a container with privileged mode'); | |||
|
|
|||
| # /dev is only accessible in privileged mode | |||
| # xen-pv does not define USB passthrough in the xml as of now | |||
| # this feature has to be added -> https://progress.opensuse.org/issues/138410 | |||
There was a problem hiding this comment.
There's no need to add this feature to test containers. We just need to find a device other than /dev/bus that is available on all systems.
Why not enhance this PR to gather this information listing /dev with and without --privileged ?
There was a problem hiding this comment.
I agree, nevertheless it won't hurt anything to provision a VM with usbs in PV. There is already a call that checks that the usbs are not there when omitting privileged flag. Not exactly only /dev/ though
grisu48
approved these changes
Oct 24, 2023
pdostal
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/dev/bus/is missing in Xen PV VMs as we do not create VMs with usb passthrough.