Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sssd: create config directory if not pre-existing #18117

Merged
merged 2 commits into from Nov 2, 2023
Merged

sssd: create config directory if not pre-existing #18117

merged 2 commits into from Nov 2, 2023

Conversation

DimStar77
Copy link
Contributor

@DimStar77 DimStar77 commented Nov 2, 2023 •
edited

@DimStar77 DimStar77 added Ready Ready for review and removed notready labels Nov 2, 2023
josegomezr
josegomezr suggested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@josegomezr josegomezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of suggestions to simplify commands. See them above/below.

I tested myself tests/console/sssd_389ds_functional and works as suggested here, will continue testing the other two.

lib/services/389ds_sssd_client.pm Outdated Show resolved Hide resolved
tests/console/sssd_389ds_functional.pm Outdated Show resolved Hide resolved
tests/migration/openldap_configuration.pm Outdated Show resolved Hide resolved
@DimStar77 @josegomezr
Apply suggestions from code review
8ce3511 
Co-authored-by: Jose D. Gomez R. <1josegomezr@gmail.com>
@DimStar77 DimStar77 merged commit 450d0fe into os-autoinst:master Nov 2, 2023
8 checks passed
@DimStar77 DimStar77 deleted the sssd branch November 2, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josegomezr josegomezr josegomezr approved these changes

Assignees
No one assigned
Labels
Ready Ready for review
Projects
None yet
Milestone
No milestone
2 participants
@DimStar77 @josegomezr