Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wicked: handle coredump of unknown source #18127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wicked: handle coredump of unknown source #18127

wants to merge 1 commit into from
+10 −1

Conversation

cfconrad
Copy link
Contributor

@cfconrad cfconrad commented Nov 6, 2023

If there are coredumps, but not related to wicked, we should not fail in before_test module.

@cfconrad
wicked: handle coredump of unknown source
7bce8e2 
If there are coredumps, but not related to wicked,
we should not fail in before_test module.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

rfan1
rfan1 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, even we don't catch any core dump files :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foursixnine foursixnine foursixnine approved these changes

@rfan1 rfan1 rfan1 approved these changes

@asmorodskyi asmorodskyi Awaiting requested review from asmorodskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cfconrad @foursixnine @rfan1