Add the conflict message to display on the openQA page #18167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepthiYV
force-pushed
the
select_pattern_test
branch
3 times, most recently
from
65405e1
to
784b605
Compare
Vogtinator
requested changes
Nov 22, 2023
| my $file_tar = "/tmp/y2logs_select_patterns.tar.bz2"; | ||
|
|
||
| select_console 'log-console'; | ||
| script_run "save_y2logs $file_tar"; |
There was a problem hiding this comment.
This should just be
sub post_fail_hook {
my $self = shift;
select_console 'log-console';
my $ret = script_output('grep -E -m 1 "nothing provides" /var/log/YaST2/y2log', proceed_on_failure => 1);
record_info("Conflict:", $ret, result => 'fail') if ($ret);
$self->SUPER::post_fail_hook();
}
Or is there some other reason to first tar the logs and immediately extract them again?
There was a problem hiding this comment.
Yeah, I missed it in this way of doing. Thanks for suggesting, and I have modified the code.
DeepthiYV
force-pushed
the
select_pattern_test
branch
from
784b605
to
2b494b4
Compare
This should happen whenever a conflict occurs
DeepthiYV
force-pushed
the
select_pattern_test
branch
from
2b494b4
to
1224c3a
Compare
Vogtinator
approved these changes
Nov 22, 2023
foursixnine
reviewed
Nov 27, 2023
| sub post_fail_hook { | ||
| my $self = shift; | ||
|
|
||
| select_console 'log-console'; |
There was a problem hiding this comment.
use serial console here instead
There was a problem hiding this comment.
Serial terminal isn't available during install. It will be available once installation/reboot done.
foursixnine
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the conflict message on the OpenQA web page whenever a conflict occurs during the installation.
https://openqa.suse.de/tests/12855037#step/select_patterns/22
https://openqa.suse.de/tests/12855039#step/select_patterns/1
Latest VRs:
https://openqa.suse.de/tests/12861755
https://openqa.suse.de/tests/12861756