Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read network device names from Network Manager #18283

Merged
merged 1 commit into from Dec 12, 2023

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Dec 11, 2023

Fix for openSUSE, makes the test independent from the network device naming scheme

@ilmanzo ilmanzo added the qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them label Dec 11, 2023
@michaelgrifalconi
Copy link
Contributor

Is there any other way instead of grep-ing text ouputs meant for user interface? Like some json output for example, to be more on the safe side (I am not a fan of using grep output as an API as might change, even if unlikely).
But on the other hand is an easy thing to fix if it will ever break, so no hard opinions here!

@ilmanzo
Copy link
Contributor Author

ilmanzo commented Dec 11, 2023

Is there any other way instead of grep-ing text ouputs meant for user interface? Like some json output for example, to be more on the safe side (I am not a fan of using grep output as an API as might change, even if unlikely). But on the other hand is an easy thing to fix if it will ever break, so no hard opinions here!

I'm not aware of any json output option (but it can be a good proposal to add in upstream nmcli :) according to the man page,

 -t | --terse
           Output is terse. This mode is designed and suitable for computer (script) processing.

we can also use -g as @Vogtinator suggests, but it's pretty much an alias

@michaelgrifalconi
Copy link
Contributor

Oh interesting, so they are aware that this is used in scripts and provide some sort of API-like text output :D Good enough I guess :)

@ilmanzo ilmanzo marked this pull request as draft December 11, 2023 08:59
@ilmanzo ilmanzo force-pushed the poo_151273_ALP_NM_bond branch 2 times, most recently from deff529 to 2e743f3 Compare December 11, 2023 09:49
@ilmanzo ilmanzo marked this pull request as ready for review December 11, 2023 10:10
@ilmanzo ilmanzo merged commit b1cd1cb into os-autoinst:master Dec 12, 2023
8 checks passed
@ilmanzo ilmanzo deleted the poo_151273_ALP_NM_bond branch December 12, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them
Projects
None yet
4 participants