Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check secure boot status with efivars #18300

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Check secure boot status with efivars #18300

merged 1 commit into from
Jan 12, 2024

Conversation

rakoenig
Copy link
Contributor

@rakoenig rakoenig commented Dec 13, 2023 •
edited

@jknphy
Copy link
Contributor

jknphy commented Jan 4, 2024

we are repeating code, we need a library or some smart adjustment in the existing code. Except for simple OOP methods in the test layer where is ok to repeat, for command line or bash stuff we need to follow DRY principle.

@rakoenig rakoenig force-pushed the check_efivars branch 2 times, most recently from 091ba78 to c317017 Compare January 4, 2024 11:39
jknphy
jknphy reviewed Jan 8, 2024
View reviewed changes
lib/YaST/EFItools.pm Outdated Show resolved Hide resolved
jknphy
jknphy reviewed Jan 8, 2024
View reviewed changes
lib/YaST/EFItools.pm Outdated Show resolved Hide resolved
jknphy
jknphy reviewed Jan 11, 2024
View reviewed changes
lib/YaST/EFItools.pm Outdated Show resolved Hide resolved
@jknphy
Copy link
Contributor

jknphy commented Jan 11, 2024

LGTM

@jknphy jknphy merged commit 29a5622 into os-autoinst:master Jan 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jknphy jknphy jknphy left review comments

@lemon-suse lemon-suse lemon-suse approved these changes

@JRivrain JRivrain JRivrain approved these changes

Assignees
No one assigned
Labels
qe-yam
Projects
None yet
Milestone
No milestone
4 participants
@rakoenig @jknphy @lemon-suse @JRivrain