Fix firewalld test for 15-SP6 #18349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepthiYV
force-pushed
the
firewalld_test
branch
from
5ba5302
to
c3c56c6
Compare
DeepthiYV
changed the title
rfan1
reviewed
Dec 21, 2023
tests/console/firewalld.pm
Outdated
| @@ -156,7 +156,7 @@ sub test_masquerading { | |||
| script_run("iptables -t nat -L --line-numbers"); | |||
| assert_script_run("iptables -t nat -L PRE_public_allow --line-numbers | sed '/^num\\|^\$\\|^Chain/d' | wc -l | tee /tmp/nr_rules_nat_pre.txt"); | |||
| assert_script_run("iptables -t nat -L POST_public_allow --line-numbers | sed '/^num\\|^\$\\|^Chain/d' | wc -l | tee /tmp/nr_rules_nat_post.txt"); | |||
| } elsif (is_leap("<16.0") || is_sle("<16")) { | |||
| } elsif (is_leap("<15.0") || is_sle("<15-SP6")) { | |||
There was a problem hiding this comment.
Is (is_leap("<15.0") good enough, how about (is_leap("<15.6")
DeepthiYV
force-pushed
the
firewalld_test
branch
from
c3c56c6
to
2207b2c
Compare
dzedro
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the firewalld test in both 15-SP6 and LEAP
Tumbleweed | 15-SP5| 15-SP6 | Leap