Fix subroutine redefined errors for sle-micro product #18388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynechen55
requested review from
mloviska and
ricardobranco777
as code owners
There are many "subroutine redefined" errors for sle-micro product in autoinst-log.txt. And these errors are caused by the "require" directive on lib/susedistribution.pm which is not used anywhere in products/sle-micro/main.pm. Removing references to this file fixes these errors.
waynechen55
force-pushed
the
wayne/fix_subroutine_redefined_slem
branch
from
752ab67
to
4af08bf
Compare
|
Seems to be a valid thing to remove, but it would be suitable to use a working test suite with more modules. Please use some of the jobs from aggregates group |
More verification runs: sle-micro-6.0-Default-x86_64-Build8.48-slem_virtualization |
|
@mloviska shall we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many "subroutine redefined" errors for sle-micro product in autoinst-log.txt. Please refer to this example.
And these errors are caused by the "require" directive on lib/susedistribution.pm which is not used anywhere in products/sle-micro/main.pm. Removing references to this file fixes these errors.
This change will not affect SLE Micro test run.
Verification Runs: