Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce yaml files in folder textmode_installation_minimal_role #18423

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Reduce yaml files in folder textmode_installation_minimal_role #18423

merged 1 commit into from
Jan 30, 2024

Conversation

tinawang123
Copy link
Contributor

@tinawang123 tinawang123 commented Jan 11, 2024 •
edited

@tinawang123 tinawang123 changed the title Reduce yaml files in folder schedule/yast/textmode_installation_minimal_role Reduce yaml files in folder textmode_installation_minimal_role Jan 11, 2024
sofiasyria
sofiasyria approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@sofiasyria sofiasyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just add the MR for changing the schedules in the Yast job group

@jknphy
Copy link
Contributor

jknphy commented Jan 16, 2024 •
edited

A couple of comments:

  • we plan to move installations to test_cases/ folder, that is not prepared yet.
  • YUI_REST_API can also be moved to job group yaml, so in the future we have this settings perhaps shared in job group yaml with some anchor/reference and later on deleted due to all we have is using yui_rest_api.

@tinawang123
Copy link
Contributor Author

A couple of comments:

* we plan to move installations to test_cases/ folder, that is not prepared yet.

* YUI_REST_API can also be moved to job group yaml, so in the future we have this settings perhaps shared in job group yaml with some anchor/reference and later on deleted due to all we have is using yui_rest_api.

I have moved 'YUI_REST_API' to the job group yaml. For the first comment, should I do anything?

@jknphy
Copy link
Contributor

jknphy commented Jan 17, 2024

A couple of comments:

* we plan to move installations to test_cases/ folder, that is not prepared yet.

* YUI_REST_API can also be moved to job group yaml, so in the future we have this settings perhaps shared in job group yaml with some anchor/reference and later on deleted due to all we have is using yui_rest_api.

I have moved 'YUI_REST_API' to the job group yaml. For the first comment, should I do anything?

test cases should be stored here: https://github.com/os-autoinst/os-autoinst-distri-opensuse/tree/master/schedule/yam/test_cases

@tinawang123
Copy link
Contributor Author

test cases should be stored here: https://github.com/os-autoinst/os-autoinst-distri-opensuse/tree/master/schedule/yam/test_cases

Moved to 'schedule/yam/test_cases/textmode_installation_minimal_role.yaml

Reduce yaml files in folder textmode_installation_minimal_role
aa4b710 
Reduce yaml files in folder
schedule/yast/textmode_installation_minimal_role
@jknphy jknphy merged commit 92be9b9 into os-autoinst:master Jan 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jknphy jknphy jknphy approved these changes

@sofiasyria sofiasyria sofiasyria approved these changes

Assignees

@sofiasyria sofiasyria

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tinawang123 @jknphy @sofiasyria