Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to detect RC builds and update release_notes_from_url #18441

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add function to detect RC builds and update release_notes_from_url #18441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/y2_installbase.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,11 @@ sub is_sles_in_gm_phase {
return !get_var('BETA');
}

sub is_sles_in_rc_phase {
my $is_RC = !script_run('grep -r RC /README.BETA');
return $is_RC;
}

sub save_remote_upload_y2logs {
my ($self, %args) = @_;

Expand Down
5 changes: 4 additions & 1 deletion tests/installation/release_notes_from_url.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,15 @@ use Utils::Backends;
use serial_terminal 'select_serial_terminal';

sub run {
my ($self) = @_;
assert_screen('release-notes-button');
select_console 'install-shell';
enter_cmd "zgrep -oh \"Got release notes.*\" /var/log/YaST2/y2log*";
assert_screen [qw(got-releasenotes-RPM got-releasenotes-URL)];
unless (match_has_tag 'got-releasenotes-URL') {
record_soft_failure('bsc#1190711 - Release notes source does NOT match expectations or not found in YaST logs, expected source: URL');
my $error_msg = 'Release notes source does NOT match expectations or not found in YaST logs, expected source: URL';
die $error_msg if ($self->is_sles_in_rc_phase() || $self->is_sles_in_gm_phase());
record_info('bsc#1190711', $error_msg);
}
reset_consoles;
select_console 'installation';
Expand Down