Add support for slowroll to bootloader_uefi #18622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
okurz
reviewed
Feb 8, 2024
okurz
reviewed
Feb 8, 2024
|
https://openqa.opensuse.org/tests/3923989 for the experimental changes to the if clauses |
okurz
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Not sure if https://openqa.opensuse.org/tests/3923989#step/journal_check/9 is related but the system could boot fine so maybe your changes are good?
mloviska
reviewed
Feb 12, 2024
okurz
reviewed
Feb 12, 2024
asdil12
force-pushed
the
slowroll
branch
2 times, most recently
from
5c0080f
to
c4702b3
Compare
okurz
requested changes
Feb 12, 2024
okurz
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VR: https://openqa.opensuse.org/tests/3923808
Ticket: https://progress.opensuse.org/issues/135731