-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sporadic failures on nmcli invocation #18713
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
fe802bf
to
7cde081
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in commit message "instrction"
The serial console somehow looks like it messes up with the interpolation of `mn_id`. Using serial terminal produces more stable results and problem seems to go away. In additional there are changes to prevent the uninitialized value warnings in autoinst-log on this jobs. https://progress.opensuse.org/issues/155170
7cde081
to
40b811b
Compare
additional benefit: tests are even faster :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have split the fix about undef variables into its own commit, but ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome 👍
The serial console somehow looks like it messes up with the interpolation
of
mn_id
. Using serial terminal produces more stable results and problemseems to go away.
In additional there are changes to prevent the uninitialized value warnings in autoinst-log on this jobs.
https://progress.opensuse.org/issues/155170