Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sporadic failures on nmcli invocation #18713

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

b10n1k
Copy link
Contributor

@b10n1k b10n1k commented Feb 22, 2024

The serial console somehow looks like it messes up with the interpolation
of mn_id. Using serial terminal produces more stable results and problem
seems to go away.
In additional there are changes to prevent the uninitialized value warnings in autoinst-log on this jobs.

https://progress.opensuse.org/issues/155170

Copy link

github-actions bot commented Feb 22, 2024

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in commit message "instrction"

lib/mm_network.pm Outdated Show resolved Hide resolved
tests/network/setup_multimachine.pm Outdated Show resolved Hide resolved
The serial console somehow looks like it messes up with the interpolation
of `mn_id`. Using serial terminal produces more stable results and problem
seems to go away.
In additional there are changes to prevent the uninitialized value
warnings in autoinst-log on this jobs.

https://progress.opensuse.org/issues/155170
@b10n1k
Copy link
Contributor Author

b10n1k commented Feb 22, 2024

additional benefit: tests are even faster :)

@b10n1k b10n1k requested a review from okurz February 22, 2024 09:43
Copy link
Contributor

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have split the fix about undef variables into its own commit, but ok.

Copy link
Member

@pdostal pdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 👍

@okurz okurz merged commit 20b62fa into os-autoinst:master Feb 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants