Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually validate network connectivity on NM MM setup #18726

Merged
merged 1 commit into from Feb 27, 2024

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Feb 23, 2024

Copy link

github-actions bot commented Feb 23, 2024

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@ggardet
Copy link
Collaborator

ggardet commented Feb 26, 2024

Should we add a max number of retry?

@asdil12
Copy link
Member Author

asdil12 commented Feb 26, 2024

That should be covered by the assert_script_run timeout.

This will anyways either return on full or wait for full until a timeout occurs.

@asdil12 asdil12 merged commit 7b5fa5d into os-autoinst:master Feb 27, 2024
9 checks passed
@asdil12 asdil12 deleted the nm branch February 27, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants