Fix configuring static IP after 40b811b7c #18739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change didn't take the code path for non-NM-based setups into account. There the default for the device parameter is determined differently and we must not assume `\S`. See https://progress.opensuse.org/issues/156067
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
okurz
approved these changes
Feb 26, 2024
Cloning parents of sle-15-SP5-Server-DVD-Updates-x86_64-Build2024-02-26T15:12+00:00-ping_client@64bit
The verification runs passed so this was luckily all that was needed. |
perlpunk
reviewed
Feb 26, 2024
perlpunk
reviewed
Feb 26, 2024
Martchus
force-pushed
the
fix-mm-network
branch
2 times, most recently
from
a141091
to
0138d45
Compare
Martchus
force-pushed
the
fix-mm-network
branch
from
0138d45
to
5d19b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change didn't take the code path for non-NM-based setups into account. There the default for the device parameter is determined differently and we must not assume
\S.See https://progress.opensuse.org/issues/156067