Make stable validate_lvm_raid1 reboot #18827
Conversation
manfredi
commented
Mar 7, 2024
manfredi
commented
- Description: [sporadic] make stable validate_lvm_raid1 reboot
- Related ticket: poo#154753
- Verification run: overview
it looks good as a draft, because at least we are trying to narrow the problem, but VR still are still not stable. Commit's first line and title should (most of the time) match and be descriptive in few characters. At the moment the commit is too short for example (to have some meaning to someone using |
manfredi
force-pushed
the
issues-154753
branch
4 times, most recently
from
e159194
to
bcd44a5
Compare
manfredi
changed the title
|
Removed the latest calls: _remove_raid_disk($config, $expected_num_devs);
_reboot();
$self->wait_boot;
_check_raid_disks_after_reboot($config, $expected_num_devs);
|
See bsc#1172203 Also the rebooting and rechecking also are not necessary.
|
Remove unneeded steps make sense. Just a minor comments for the description for the test, only a summary while no test steps, not very friendly for reader. Maybe that's already out of the scope of your ticket, we can discuss such things later. |
@lemon-suse the motivations are explained in the poo#154753 comments |
|
|
||
| sub _reboot { | ||
| record_info('system reboots'); | ||
| power_action('reboot', textmode => 'textmode'); |
There was a problem hiding this comment.
please remove the import on top.
In fact, my comments only related with the test module that no test steps in description, and this is not only for this test module. Your PR looks good to me. I mean maybe later we can raise a new ticket to update test modules for test steps in description. |
|
@lemon-suse besides the approvals (before merging) please ensure that all the comments are addressed with answers or tickets. |
